Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012223Openbravo ERPZ. Otherspublic2010-02-11 10:102010-03-10 18:29
Reportershuehner 
Assigned Toshuehner 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012223: api check build 287 fails - part1
Descriptionhttp://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/287/console [^]

problem is:
 [checkAPI] +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] Errors in API model validation
 [checkAPI] +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] Check Constraint addition: table: M_ATTRIBUTESET - Constraint: M_ATTRIBUTESET_ISATSETVAL_CHK
 [checkAPI] Check Constraint addition: table: M_PRODUCT - Constraint: M_PRODUCT_ATSETVALTYPE_CHK
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0012224 closed marvintm api check build 287 fails - part2 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-02-11 10:10shuehnerNew Issue
2010-02-11 10:10shuehnerAssigned To => rafaroda
2010-02-11 10:10shuehnerOBNetwork customer => No
2010-02-11 10:10shuehnerNote Added: 0024150
2010-02-11 10:28rafarodaNote Added: 0024152
2010-02-11 10:28rafarodaAssigned Torafaroda => pjuvara
2010-02-11 10:28rafarodaStatusnew => scheduled
2010-02-11 11:17rafarodaIssue Monitored: rafaroda
2010-02-11 12:01rafarodaRelationship addedrelated to 0012224
2010-02-11 13:19pjuvaraNote Added: 0024164
2010-02-11 15:20rafarodaNote Added: 0024173
2010-02-12 10:28pjuvaraAssigned Topjuvara => rafaroda
2010-02-12 10:28pjuvaraNote Added: 0024196
2010-02-13 13:48iciordiaAssigned Torafaroda => shuehner
2010-02-14 14:37hgbotCheckin
2010-02-14 14:37hgbotNote Added: 0024223
2010-02-14 14:37hgbotStatusscheduled => resolved
2010-02-14 14:37hgbotResolutionopen => fixed
2010-02-14 14:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/4115163d25d6018ed95b5d5610651cc5728e7687 [^]
2010-02-14 15:53shuehnerStatusresolved => closed
2010-02-15 00:00anonymoussf_bug_id0 =>
2010-03-10 18:29anonymoussf_bug_id => 2968048

Notes
(0024150)
shuehner   
2010-02-11 10:10   
first one looks like constraint is for a new column so should not be an issues for upgrades, second one is a changed constraint definition.
(0024152)
rafaroda   
2010-02-11 10:28   
Both are related to the Attribute Set Instance Review project http://wiki.openbravo.com/wiki/Projects/Attribute_set_instance_review [^]

Both are check constraints added to new created columns http://wiki.openbravo.com/wiki/Projects/Attribute_set_instance_review#Technical_Documentation [^]

1) New column ISONEATTRSETVALREQUIRED for table M_ATTRIBUTESET with new check constraint M_ATTRIBUTESET_ISATSETVAL_CHK

2) New column ATTRSETVALUETYPE for table M_PRODUCT with new check constraint M_PRODUCT_ATSETVALTYPE_CHK
(0024164)
pjuvara   
2010-02-11 13:19   
Rafa,

can you please add your assessment on the risk of this change and your recommendation?

Thanks,

Paolo
(0024173)
rafaroda   
2010-02-11 15:20   
1) ISONEATTRSETVALREQUIRED is a new column in M_ATTRIBUTESET table and M_ATTRIBUTESET_ISATSETVAL_CHK is a new check constraint that only affects this column: risk zero.

2) ATTRSETVALUETYPE is a new column in M_PRODUCT table and M_PRODUCT_ATSETVALTYPE_CHK is a new check constraint that affects both this column and an existing one (M_ATTRIBUTESETINSTANCE_ID): risk low. The risk is low since an onCreateDefault value has been added in order that the check constraint is complied https://code.openbravo.com/erp/devel/pi/file/tip/src-db/database/model/tables/M_PRODUCT.xml#l280 [^]
(0024196)
pjuvara   
2010-02-12 10:28   
Accepted. Please send notifications with risk level low.
(0024223)
hgbot   
2010-02-14 14:37   
Repository: erp/devel/api-checks
Changeset: 4115163d25d6018ed95b5d5610651cc5728e7687
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Feb 14 14:37:56 2010 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/4115163d25d6018ed95b5d5610651cc5728e7687 [^]

Fixed 12223: accept change

---
M model/model/tables/M_ATTRIBUTESET.xml
M model/model/tables/M_PRODUCT.xml
---