Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012160Openbravo ERPA. Platformpublic2010-02-05 14:242010-03-10 18:29
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version2.50MP12 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012160: Do not initialize dal in apply.modules if not needed
DescriptionApply.modules task uses DAL to import reference data of modules.

The problem is that DAL is always initialized regardless it is needed, making the process slower if the modules to be applied don't have reference data.
Steps To Reproduce
Proposed SolutionDo not initialize dal if not needed.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-02-05 14:24alostaleNew Issue
2010-02-05 14:24alostaleAssigned To => alostale
2010-02-05 14:24alostaleOBNetwork customer => No
2010-02-05 14:26hgbotCheckin
2010-02-05 14:26hgbotNote Added: 0023992
2010-02-05 14:26hgbotStatusnew => resolved
2010-02-05 14:26hgbotResolutionopen => fixed
2010-02-05 14:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4d779c084f41a72925ae0e657c43773a12870de9 [^]
2010-02-05 14:34hgbotCheckin
2010-02-05 14:34hgbotNote Added: 0023993
2010-02-05 14:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4d779c084f41a72925ae0e657c43773a12870de9 [^] => http://code.openbravo.com/erp/devel/pi/rev/7e181b15371551ed217f995d3849e83ec195576b [^]
2010-02-15 17:36hudsonbotCheckin
2010-02-15 17:36hudsonbotNote Added: 0024299
2010-02-15 17:36hudsonbotCheckin
2010-02-15 17:36hudsonbotNote Added: 0024300
2010-02-15 17:36hudsonbotCheckin
2010-02-15 17:36hudsonbotNote Added: 0024301
2010-02-16 17:06marvintmNote Added: 0024424
2010-02-16 17:06marvintmStatusresolved => closed
2010-02-16 17:06marvintmFixed in Version => 2.50MP12
2010-02-17 00:01anonymoussf_bug_id0 =>
2010-03-10 18:29anonymoussf_bug_id => 2968019

Notes
(0023992)
hgbot   
2010-02-05 14:26   
Repository: erp/devel/pi
Changeset: 4d779c084f41a72925ae0e657c43773a12870de9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 05 14:26:41 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4d779c084f41a72925ae0e657c43773a12870de9 [^]

fixed bug 12160: Do not initialize dal in apply.modules if not needed

---
M src/org/openbravo/erpCommon/modules/ApplyModule.java
M src/org/openbravo/erpCommon/modules/ApplyModuleTask.java
---
(0023993)
hgbot   
2010-02-05 14:34   
Repository: erp/devel/pi
Changeset: 7e181b15371551ed217f995d3849e83ec195576b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 05 14:34:04 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7e181b15371551ed217f995d3849e83ec195576b [^]

related to issue 12160
made log4j private final
removed System.out

---
M src/org/openbravo/erpCommon/modules/ApplyModuleTask.java
---
(0024299)
hudsonbot   
2010-02-15 17:36   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/4d779c084f41 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2596487a564c [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16391.obx [^]
(0024300)
hudsonbot   
2010-02-15 17:36   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/7e181b153715 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2596487a564c [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16391.obx [^]
(0024301)
hudsonbot   
2010-02-15 17:36   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8645e0e64c6c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2596487a564c [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16391.obx [^]
(0024424)
marvintm   
2010-02-16 17:06   
Tested that DAL is not initialized if there are no modules containing reference data in the system, and that it is initialized when those modules exist.