Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012127Openbravo ERPA. Platformpublic2010-02-04 10:132010-03-10 18:29
Reportershuehner 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012127: API check build 279 fails
DescriptionThis api check build fails:

http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/279/console [^]

  Added mandatory column without onCreateDefault: C_TAX.DOCTAXAMOUNT

This is a false positive. The new column does have a 'normal' default-value and no onCreateDefault. A recent change to dbsourcemanager allows this situation and uses the normal default value for the column.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0012128 scheduled marvintm Cleanup of all tables/xml-files with onCreateDefault == default -> the onCreateDefault value can be removed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-02-04 10:13shuehnerNew Issue
2010-02-04 10:13shuehnerAssigned To => alostale
2010-02-04 10:18shuehnerNote Added: 0023943
2010-02-04 10:27shuehnerRelationship addedrelated to 0012128
2010-02-04 10:30hgbotCheckin
2010-02-04 10:30hgbotNote Added: 0023944
2010-02-04 10:30hgbotStatusnew => resolved
2010-02-04 10:30hgbotResolutionopen => fixed
2010-02-04 10:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/3d7ad5b1bf79929700654ce94623bf7995256b86 [^]
2010-02-04 10:41hgbotCheckin
2010-02-04 10:41hgbotNote Added: 0023945
2010-02-04 10:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/3d7ad5b1bf79929700654ce94623bf7995256b86 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/f9b3896250a312babd47de43cfb714ef8ba67ed1 [^]
2010-02-04 10:43alostaleNote Added: 0023946
2010-02-04 10:43alostaleAssigned Toalostale => eduardo_Argal
2010-02-04 10:43alostaleStatusresolved => new
2010-02-04 10:43alostaleResolutionfixed => open
2010-02-04 12:27alostaleAssigned Toeduardo_Argal => alostale
2010-02-04 12:27hgbotCheckin
2010-02-04 12:27hgbotNote Added: 0023954
2010-02-04 12:27hgbotStatusnew => resolved
2010-02-04 12:27hgbotResolutionopen => fixed
2010-02-04 12:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/f9b3896250a312babd47de43cfb714ef8ba67ed1 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/562d09be311a20a4e2a8ac400dce1b84ac8aee0e [^]
2010-02-04 12:27alostaleNote Added: 0023955
2010-02-04 12:27alostaleStatusresolved => closed
2010-02-04 17:56hgbotCheckin
2010-02-04 17:56hgbotNote Added: 0023961
2010-02-04 17:56hgbotStatusclosed => resolved
2010-02-04 17:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/562d09be311a20a4e2a8ac400dce1b84ac8aee0e [^] => http://code.openbravo.com/erp/devel/pi/rev/22752049c9f57c51a178231ddc6d0b4875fd241c [^]
2010-02-15 17:36hudsonbotCheckin
2010-02-15 17:36hudsonbotNote Added: 0024293
2010-03-09 21:06shuehnerNote Added: 0025199
2010-03-09 21:06shuehnerStatusresolved => closed
2010-03-10 17:21anonymoussf_bug_id0 =>
2010-03-10 18:29anonymoussf_bug_id => 2968011

Notes
(0023943)
shuehner   
2010-02-04 10:18   
We need to recheck with the developer (eduardo) if the default is also fine as oncreateDefault. if yes change the api-test.
(0023944)
hgbot   
2010-02-04 10:30   
Repository: erp/devel/api-checks
Changeset: 3d7ad5b1bf79929700654ce94623bf7995256b86
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 04 10:30:22 2010 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3d7ad5b1bf79929700654ce94623bf7995256b86 [^]

fixed issue 12127: API check build 279 fails

---
M model/model/tables/C_TAX.xml
---
(0023945)
hgbot   
2010-02-04 10:41   
Repository: erp/devel/api-checks
Changeset: f9b3896250a312babd47de43cfb714ef8ba67ed1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 04 10:41:47 2010 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/f9b3896250a312babd47de43cfb714ef8ba67ed1 [^]

issue 12127: Reverted change, waiting for confirmation

---
M model/model/tables/C_TAX.xml
---
(0023946)
alostale   
2010-02-04 10:43   
Eduardo, can you confirm current default value is ok for existing data?

If so you can apply again changeset http://code.openbravo.com/erp/devel/api-checks/rev/3d7ad5b1bf79929700654ce94623bf7995256b86 [^] if not fix the onCreateDefault for that column.

Thanks
(0023954)
hgbot   
2010-02-04 12:27   
Repository: erp/devel/api-checks
Changeset: 562d09be311a20a4e2a8ac400dce1b84ac8aee0e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 04 12:27:06 2010 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/562d09be311a20a4e2a8ac400dce1b84ac8aee0e [^]

fixed issue 12127: API check build 279 fails

---
M model/model/tables/C_TAX.xml
---
(0023955)
alostale   
2010-02-04 12:27   
confirmed
(0023961)
hgbot   
2010-02-04 17:56   
Repository: erp/devel/pi
Changeset: 22752049c9f57c51a178231ddc6d0b4875fd241c
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Thu Feb 04 17:54:14 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/22752049c9f57c51a178231ddc6d0b4875fd241c [^]

Fixes bug 0012127: API check build 279 fails

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0024293)
hudsonbot   
2010-02-15 17:36   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/22752049c9f5 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2596487a564c [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16391.obx [^]
(0025199)
shuehner   
2010-03-09 21:06   
api check issue. closing