Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012106Openbravo ERPA. Platformpublic2010-02-02 20:512010-04-19 21:10
Reportershuehner 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP15 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012106: record identifier returned from dal uses ' ' as separator of columns, but normal pl-version uses ' - '
DescriptionThe record identifier as returned by dal and the normal pl-based version are different

' ' vs. ' - '

and the date formatting seems to be different also:

dal: 80005 2006-08-31 00:00:00.0 250.56
wad-window: 80005 - 31-08-2006 - 250.56
Steps To Reproduce
Proposed SolutionPerhaps dal record identifier building should be changed to be consistent with the pl-based identifiers.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0012901 closed mtaal OBDal.getInstance().getConnection() does not setup dateFormat correctly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-02-02 20:51shuehnerNew Issue
2010-02-02 20:51shuehnerAssigned To => mtaal
2010-02-08 10:51alostaleStatusnew => scheduled
2010-03-10 17:47hgbotCheckin
2010-03-10 17:47hgbotNote Added: 0025216
2010-03-10 17:47hgbotStatusscheduled => resolved
2010-03-10 17:47hgbotResolutionopen => fixed
2010-03-10 17:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ee232d567bd94c8045752d998f5a7d61193f1e52 [^]
2010-03-12 13:46shuehnerNote Added: 0025292
2010-03-12 13:46shuehnerStatusresolved => new
2010-03-12 13:46shuehnerResolutionfixed => open
2010-03-12 13:48shuehnerNote Added: 0025293
2010-03-12 22:41hudsonbotCheckin
2010-03-12 22:41hudsonbotNote Added: 0025417
2010-03-15 07:47alostaleStatusnew => scheduled
2010-03-15 07:47alostalefix_in_branch => pi
2010-03-15 12:22mtaalNote Added: 0025473
2010-03-16 07:08hgbotCheckin
2010-03-16 07:08hgbotNote Added: 0025504
2010-03-16 07:08hgbotStatusscheduled => resolved
2010-03-16 07:08hgbotResolutionopen => fixed
2010-03-16 07:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ee232d567bd94c8045752d998f5a7d61193f1e52 [^] => http://code.openbravo.com/erp/devel/pi/rev/d0560422ea808c40a2dff7dac7ea4d330b570968 [^]
2010-03-16 11:03mtaalNote Added: 0025529
2010-03-16 11:03mtaalStatusresolved => new
2010-03-16 11:03mtaalResolutionfixed => open
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025556
2010-03-19 17:32hgbotCheckin
2010-03-19 17:32hgbotNote Added: 0025624
2010-03-19 17:32hgbotStatusnew => resolved
2010-03-19 17:32hgbotResolutionopen => fixed
2010-03-19 17:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d0560422ea808c40a2dff7dac7ea4d330b570968 [^] => http://code.openbravo.com/erp/devel/pi/rev/9f2ed50b5162db423ad60c5d123f202f5e973546 [^]
2010-03-19 20:47mtaalNote Added: 0025627
2010-04-07 14:27shuehnerRelationship addedrelated to 0012901
2010-04-07 15:11shuehnerNote Added: 0025943
2010-04-07 15:11shuehnerStatusresolved => closed
2010-04-07 15:11shuehnerFixed in Version => 2.50MP15
2010-04-08 00:00anonymoussf_bug_id0 => 2983494
2010-04-19 21:10hudsonbotCheckin
2010-04-19 21:10hudsonbotNote Added: 0026356

Notes
(0025216)
hgbot   
2010-03-10 17:47   
Repository: erp/devel/pi
Changeset: ee232d567bd94c8045752d998f5a7d61193f1e52
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Mar 10 17:52:48 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ee232d567bd94c8045752d998f5a7d61193f1e52 [^]

Fixes issue 12106: record identifier returned from dal uses ' ' as separator of columns, but normal pl-version uses ' - '

---
M src-test/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0025292)
shuehner   
2010-03-12 13:46   
Reopening as the fix done is only a partial fix.

However the part committed is fine so not need to back it out until the whole fix is done.
(0025293)
shuehner   
2010-03-12 13:48   
Issue left open is formatting of dates which is still different for sql/dal-identifiers:

Example identifier of a sales order:
60001 - 12-03-2010 - 40.60 sql identifier
60001 - 2010-03-12 00:00:00.0 - 40.60 dal identifier

Improvement not for the testcase done: really compare text output of sql-identifier function and dal-getidentifier function.

AD_COLUMN_IDENTIFIER(TO_CHAR('M_Product'), M_Product_ID, 'en_US') gives the english identifier of the given product.
(0025417)
hudsonbot   
2010-03-12 22:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ee232d567bd9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025473)
mtaal   
2010-03-15 12:22   
Another change which maybe considered as part of this issue:
https://issues.openbravo.com/view.php?id=12564 [^]
show the value together with the name for list references

Possibly this function should be re-implemented when implementation translation/i18n in the DAL.
(0025504)
hgbot   
2010-03-16 07:08   
Repository: erp/devel/pi
Changeset: d0560422ea808c40a2dff7dac7ea4d330b570968
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 16 07:15:09 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d0560422ea808c40a2dff7dac7ea4d330b570968 [^]

fixes issue 12106: record identifier returned from dal uses ' ' as separator of columns, but normal pl-version uses ' - '

---
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0025529)
mtaal   
2010-03-16 11:03   
Commit done to early, will be done again in 3 days
(0025556)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d0560422ea80 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025624)
hgbot   
2010-03-19 17:32   
Repository: erp/devel/pi
Changeset: 9f2ed50b5162db423ad60c5d123f202f5e973546
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Mar 19 17:40:09 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9f2ed50b5162db423ad60c5d123f202f5e973546 [^]

fixes issue 12106: record identifier returned from dal uses ' ' as separator of columns, but normal pl-version uses ' - '

---
M src-test/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0025627)
mtaal   
2010-03-19 20:47   
I have a testcase which reads a record using the dal and computes the date through a stored procedure.
this works for postgres but fails for oracle, it seems that oracle does not follow the date format defined in the properties.

expected:<200000 - 29-[MAR-]06 - 3233.49 - 0 - 0> but was:<200000 - 29-[03-20]06 - 3233.49 - 0 - 0>
Stacktrace

junit.framework.ComparisonFailure: expected:<200000 - 29-[MAR-]06 - 3233.49 - 0 - 0> but was:<200000 - 29-[03-20]06 - 3233.49 - 0 - 0>
    at org.openbravo.test.dal.IssuesTest.test12106(IssuesTest.java:134)
    at org.openbravo.test.base.BaseTest.runTest(BaseTest.java:166)
(0025943)
shuehner   
2010-04-07 15:11   
Tested in pi/oracle, rev: 6ba00074e974. DAL based identifier and identifier shown in a wad window are now the same with respect to seperator char and date-formatting. Not testing the testcase issue as it depends on a solution for 12901 first.
(0026356)
hudsonbot   
2010-04-19 21:10   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/9f2ed50b5162 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]