Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012040Openbravo ERPZ. Otherspublic2010-01-21 19:122010-03-12 22:40
Reporterelopio 
Assigned Todbaz 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP14 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012040: Use the same identifier for all message box titles and messages
DescriptionWhen all identifiers are consistent in the application we can use only one automation object for each element to simulate user actions on them.

The message box shown in the pop up doesn't have the same message box identifiers as the rest of the application.

The title identifier should be "messageBoxIDTitle" and the message identifier should be "messageBoxIDMessage", because those are the values used in a lot of sections.

Instead it has "paramTitle" as title id and "paramText" as message id.

I'll add comments to this bug when I find more message boxes using other identifiers.
Steps To ReproduceLogin with System Administrator user:

    * "Username": Openbravo
    * "Password": openbravo

Go to General Setup || Process Scheduling || Process Request || Process Request

Select the Acct Server Process record.

Click the "(Re|Un)schedule Process" button.

See the page source:

<SPAN>
  <DIV class="MessageBox_TextTitle" id="paramTitle">Process Request</DIV>
  <DIV class="MessageBox_TextDescription" id="paramText">The process has been rescheduled successfully.</DIV>
<SPAN>
Proposed SolutionChange the identifier of title to messageBoxIDTitle
Change the identifier of message to messageBoxIDMessage
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0011804 closed dbaz Message box without id in rebuild pop up. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-01-21 19:12elopioNew Issue
2010-01-21 19:12elopioAssigned To => rafaroda
2010-01-21 19:12elopioOBNetwork customer => No
2010-01-21 19:18elopioRelationship addeddepends on 0011804
2010-01-21 19:19hgbotCheckin
2010-01-21 19:19hgbotNote Added: 0023723
2010-01-21 19:19hgbotFixed in SCM revision => http://code.openbravo.com/tools/automation/main/rev/85d644f41a44e668cc0d99fb9c4682991bfb5f0e [^]
2010-02-04 19:27elopioNote Added: 0023966
2010-02-05 06:31hgbotCheckin
2010-02-05 06:31hgbotNote Added: 0023977
2010-02-05 06:31hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/main/rev/85d644f41a44e668cc0d99fb9c4682991bfb5f0e [^] => http://code.openbravo.com/tools/automation/main/rev/76935e553b78f79876d34ec33bf05a158d9b7609 [^]
2010-02-11 11:20rafarodaAssigned Torafaroda => adrianromero
2010-03-02 14:19dbazAssigned Toadrianromero => dbaz
2010-03-02 14:37hgbotCheckin
2010-03-02 14:37hgbotNote Added: 0024947
2010-03-02 14:37hgbotStatusnew => resolved
2010-03-02 14:37hgbotResolutionopen => fixed
2010-03-02 14:37hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/main/rev/76935e553b78f79876d34ec33bf05a158d9b7609 [^] => http://code.openbravo.com/erp/devel/pi/rev/61af0928920b27864c15ab0fea12cc7fd97c02ae [^]
2010-03-03 07:23sureshbabuNote Added: 0024976
2010-03-03 07:23sureshbabuStatusresolved => closed
2010-03-03 07:23sureshbabuFixed in Version => 2.50MP13
2010-03-04 07:07hgbotCheckin
2010-03-04 07:07hgbotNote Added: 0025040
2010-03-08 16:04jpabloaeFixed in Version2.50MP13 => 2.50MP14
2010-03-10 17:21anonymoussf_bug_id0 =>
2010-03-10 18:29anonymoussf_bug_id => 2967990
2010-03-12 22:40hudsonbotCheckin
2010-03-12 22:40hudsonbotNote Added: 0025373

Notes
(0023723)
hgbot   
2010-01-21 19:19   
Repository: tools/automation/main
Changeset: 85d644f41a44e668cc0d99fb9c4682991bfb5f0e
Author: Leo Arias <leo.arias <at> openbravo.com>
Date: Thu Jan 21 12:17:52 2010 -0600
URL: http://code.openbravo.com/tools/automation/main/rev/85d644f41a44e668cc0d99fb9c4682991bfb5f0e [^]

Changed the identifiers of message box elements because of issue 12040.
Added an alternate constructor to MessageBox object to use in this cases.

---
M src-test/com/openbravo/test/integration/common/MessageBox.java
M src-test/com/openbravo/test/integration/general/processscheduling/ProcessRequestPopUp.java
---
(0023966)
elopio   
2010-02-04 19:27   
The message box for generate invoices also has a different title and message id. And in spanish.

Reload Current Page Sales Management || Transactions || Generate Invoices
Select a date and click OK.

This is the source:

<span>
  <div id="paramTitulo" class="MessageBox_TextTitle">Process completed successfully</div>
  <div id="paramTexto" class="MessageBox_TextDescription">Created: 4, Invoice No. I/13, Invoice No. I/14, Invoice No. I/15, Invoice No. I/16</div>
  <div class="MessageBox_TextSeparator"></div>
</span>
(0023977)
hgbot   
2010-02-05 06:31   
Repository: tools/automation/main
Changeset: 76935e553b78f79876d34ec33bf05a158d9b7609
Author: Leo Arias <leo.arias <at> openbravo.com>
Date: Thu Feb 04 23:31:53 2010 -0600
URL: http://code.openbravo.com/tools/automation/main/rev/76935e553b78f79876d34ec33bf05a158d9b7609 [^]

Modifyied the verification of the message in accounting reset test.
Note to issue 12040:
Reset Accounting Pop Up has not the standard identifiers for the message box.
(Financial Management | Accounting | Transactions | Reset Accounting)

---
M src-test/com/openbravo/test/integration/financial/accounting/transactions/ResetAccounting.java
M src-test/com/openbravo/test/integration/smoke/accountingprocess/ACC0020_ResetAccountingProcess.java
---
(0024947)
hgbot   
2010-03-02 14:37   
Repository: erp/devel/pi
Changeset: 61af0928920b27864c15ab0fea12cc7fd97c02ae
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Mar 02 14:37:05 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/61af0928920b27864c15ab0fea12cc7fd97c02ae [^]

Fixed issue 12040: Now all MessageBoxes have the same ID

---
M src/org/openbravo/base/secureApp/Advise.html
M src/org/openbravo/base/secureApp/Advise.xml
M src/org/openbravo/base/secureApp/AdvisePopUp.html
M src/org/openbravo/base/secureApp/AdvisePopUp.xml
M src/org/openbravo/base/secureApp/AdvisePopUpRefresh.html
M src/org/openbravo/base/secureApp/AdvisePopUpRefresh.xml
M src/org/openbravo/base/secureApp/Error.html
M src/org/openbravo/base/secureApp/Error.xml
M src/org/openbravo/base/secureApp/ErrorPopUp.html
M src/org/openbravo/base/secureApp/ErrorPopUp.xml
M src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.html
M src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.xml
M src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.html
M src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.xml
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintStatus.html
---
(0024976)
sureshbabu   
2010-03-03 07:23   
Tested working fine
(0025040)
hgbot   
2010-03-04 07:07   
Repository: tools/automation/main
Changeset: d4c2d8d6e291253aa124ca2ddfc90cebd1ed1e16
Author: Leo Arias <leo.arias <at> openbravo.com>
Date: Thu Mar 04 00:11:31 2010 -0600
URL: http://code.openbravo.com/tools/automation/main/rev/d4c2d8d6e291253aa124ca2ddfc90cebd1ed1e16 [^]

Updated message boxes because issue 12040 is now resolved.

---
M src-test/com/openbravo/test/integration/erp/gui/MessageBox.java
M src-test/com/openbravo/test/integration/erp/gui/financial/accounting/transactions/ResetAccounting.java
M src-test/com/openbravo/test/integration/erp/gui/general/processscheduling/ProcessRequestPopUp.java
M src-test/com/openbravo/test/integration/erp/gui/sales/transactions/GenerateInvoices.java
---
(0025373)
hudsonbot   
2010-03-12 22:40   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/61af0928920b [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]