0011699: 347 model does not group by Tax ID - Openbravo Issue Tracking System

Steps to test the fix:

From a functional side, we will create different business partners for different store locations but each of these business partners will have the same Tax ID (NIF) since they are really the same company. This is not the correct way of defining different locations for the same business partner (Tax ID should be an unique constraint) but let's assume the following scenario.

1) Create a new business partner named "My Store Bilbao" with Tax ID = 111 and Business Partner category = Standard.
1.1) Create a new location for this business partner with address "My Street - - 10000 - Bilbao - VIZCAYA - Spain"
1.2) In Customer tab select Price List = General Sales; Form of Payment = Cash; Payment Terms = Fifteen days
1.3) In Vendor/Creditor tab select Purchase Price List = Purchase; Form of Payment = Cheque; Payment Terms = Immediate
1.4) Create and complete a purchase invoice for business partner "My Store Bilbao" with quantity > 5.000
1.5) Create and complete a sales invoice for business partner "My Store Bilbao" with quantity > 5.000

2) Create a new business partner named "My Store Vitoria 1" with Tax ID = 111 and Business Partner category = Standard.
2.1) Create a new location for this business partner with address "My Street - - 20000 - Vitoria - ALAVA - Spain"
2.2) In Customer tab select Price List = General Sales; Form of Payment = Cash; Payment Terms = Fifteen days (the same as 1)
2.3) In Vendor/Creditor tab select Purchase Price List = Purchase; Form of Payment = Cheque; Payment Terms = Immediate (the same as 1)
2.4) Create and complete a purchase invoice for business partner "My Store Vitoria 1" with quantity > 5.000
2.5) Create and complete a sales invoice for business partner "My Store Vitoria 1" with quantity > 5.000

3) Create a new business partner named "My Store Vitoria 2" with Tax ID = 111 and Business Partner category = Standard.
3.1) Create a new location for this business partner with address "My Street - - 20000 - Vitoria - ALAVA - Spain"
3.2) In Customer tab select Price List = General Sales; Form of Payment = Cash; Payment Terms = Fifteen days (the same as 1)
3.3) In Vendor/Creditor tab select Purchase Price List = Purchase; Form of Payment = Cheque; Payment Terms = Immediate (the same as 1)
3.4) Create and complete a purchase invoice for business partner "My Store Vitoria 2" with quantity > 5.000
3.5) Create and complete a sales invoice for business partner "My Store Vitoria 2" with quantity > 5.000

4) Create a new business partner named "Different Store" with Tax ID = 222 (this will be a different company) and Business Partner category = Standard.
4.1) Create a new location for this business partner with address "Different Street - - 10000 - Bilbao - VIZCAYA - Spain"
4.2) In Customer tab select Price List = General Sales; Form of Payment = Cash; Payment Terms = Fifteen days
4.3) In Vendor/Creditor tab select Purchase Price List = Purchase; Form of Payment = Cheque; Payment Terms = Immediate
4.4) Create and complete a purchase invoice for business partner "Different Store"
4.5) Create and complete a sales invoice for business partner "Different Store"

5) In Financial Management || Accounting || Analysis Tools || Generate 347 Model, select:
* From Date = 01-01-2010
* To Date = 01-01-2011
* Type = RD 1065/2007
* New
Click on 'HTML Format' button and the file generated should contain only 5 rows:
A) The header
B) The sales information for 'My Store' company (with tax ID = 111)
C) The purchase information for 'My Store' company (with tax ID = 111)
D) The sales information for 'Different' company (with tax ID = 222)
E) The purchase information for 'Different' company (with tax ID = 222)

Repeat this 5th step changing the Type and selecting Complementary or Sustitutive: in all the cases only these 5 lines must to appear in the file, with different formats. Without the fix, the 2 lines of 'My Store' company were 6, 2 (sales and purchase) per each business partner/store.

Known issue: the name selected for one company if there are many business partner representing this company (with the same Tax ID) is taken as the first alphanumerical business partner name. The same happens for the region digits. Since we are not working with C_BPartner_ID, there could be a mismatch between the name displayed and the region digits displayed. In any case, the relevant information in the 347 report is the Tax ID.