Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011618Openbravo ERP03. Procurement managementpublic2009-12-02 17:092010-01-19 01:41
Reporternetworkb 
Assigned Togorkaion 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40MP11 
Target Version2.40MP12Fixed in Version2.50MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011618: the price adjustment isn't correct if in the price adustment includes a Price List
DescriptionWhen create an order using 'Requisition to order' the price adjustment isn't correct if in the price adjustment includes a Price List
Steps To Reproduce-As Openbravo Admin go to Master Data Management || Pricing || Price Adjustments || Adjustments
-Create a new record:
    -Starting Date: 01-01-2009
    -Discount %: 10.
    -Include Price Lists: All selected
    -Included Business Partners: All selected
-Save and go to Adjustments >> Business Partner
    -BP: McGiver Supplies
-Save and go to Adjustments >> Price List
-Create a new record:
    -Price List: Purchase
-Save

-Go to Procurement Management || Transactions || Requisition
-Create a new record:
    -BP: McGiver Supplies
    -Price List: Purchase
-Save and go to Lines, create a new record
    -Product: Hammer
    -Need by date: 25-11-2009
    -Quantity: 20
-Save and go back to the Header, Complete

-Go to Procurement Management || Transactions || Requisition To Order
-Select the requisition created, and add
-Created

-Go to Procurement Management || Transactions || Purchase Order
-Select the ordered created.
-Go to Price Adjustement
Proposed SolutionReview both:
* 'Requisition to order' process
* 'Create Purchase Order' process inside Procurement Management || Transactions || Manage Requisitions || Header

They have to take into account Price Adjustments when creating purchase orders.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00114642.50MP11 closed gorkaion Error when Create Purchase Order from a Requisition 
depends on backport 00117062.40MP12 closed gorkaion the price adjustment isn't correct if in the price adustment includes a Price List 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-02 17:09networkbNew Issue
2009-12-02 17:09networkbAssigned To => rafaroda
2009-12-04 09:23networkbTarget Version2.50MP12 => 2.40MP12
2009-12-07 19:53psarobeNote Added: 0022504
2009-12-07 19:53psarobeStatusnew => feedback
2009-12-09 09:32networkbNote Added: 0022564
2009-12-09 09:32networkbStatusfeedback => new
2009-12-09 13:03rafarodaPriorityimmediate => high
2009-12-09 13:03rafarodaDescription Updated
2009-12-09 13:03rafarodaSteps to Reproduce Updated
2009-12-09 13:04rafarodaStatusnew => scheduled
2009-12-09 13:04rafarodafix_in_branch => pi
2009-12-14 12:28rafarodaRelationship addedrelated to 0011464
2009-12-14 16:18hgbotCheckin
2009-12-14 16:18hgbotNote Added: 0022762
2009-12-14 16:18hgbotStatusscheduled => resolved
2009-12-14 16:18hgbotResolutionopen => fixed
2009-12-14 16:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d8660a4ab9a7e374d01c0028bf205c39063bcc38 [^]
2009-12-14 16:19rafarodaNote Added: 0022764
2009-12-14 16:21rafarodaNote Edited: 0022764
2009-12-15 08:58hudsonbotCheckin
2009-12-15 08:58hudsonbotNote Added: 0022803
2009-12-15 12:17arunkumarNote Added: 0022829
2009-12-15 12:17arunkumarStatusresolved => closed
2009-12-15 12:17arunkumarFixed in Version => 2.50MP10
2009-12-16 00:00anonymoussf_bug_id0 => 2915148
2009-12-23 19:29gorkaionAssigned Torafaroda => gorkaion
2009-12-23 19:29gorkaionNote Added: 0023044
2009-12-23 19:29gorkaionStatusclosed => new
2009-12-23 19:29gorkaionResolutionfixed => open
2009-12-23 19:29gorkaionFixed in Version2.50MP10 =>
2009-12-30 19:00psarobeStatusnew => scheduled
2010-01-08 17:38rafarodaNote Edited: 0022764
2010-01-08 17:44hgbotCheckin
2010-01-08 17:44hgbotNote Added: 0023268
2010-01-08 17:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d8660a4ab9a7e374d01c0028bf205c39063bcc38 [^] => http://code.openbravo.com/erp/devel/pi/rev/293034f2122236dbc3ebe8e178b7714a380735ba [^]
2010-01-08 17:44hgbotCheckin
2010-01-08 17:44hgbotNote Added: 0023271
2010-01-08 17:44hgbotStatusscheduled => resolved
2010-01-08 17:44hgbotResolutionopen => fixed
2010-01-08 17:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/293034f2122236dbc3ebe8e178b7714a380735ba [^] => http://code.openbravo.com/erp/devel/pi/rev/63e7d6c5520a8d2b6c0edfcd69ed42d55ce7f1ce [^]
2010-01-12 07:04sureshbabuNote Added: 0023325
2010-01-12 07:04sureshbabuStatusresolved => closed
2010-01-12 07:04sureshbabuFixed in Version => 2.50MP10
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023533
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023536

Notes
(0022504)
psarobe   
2009-12-07 19:53   
What is not correct? the price calculated? Can you please be more specific?
(0022564)
networkb   
2009-12-09 09:32   
The price adjustment isn't correct
(0022762)
hgbot   
2009-12-14 16:18   
Repository: erp/devel/pi
Changeset: d8660a4ab9a7e374d01c0028bf205c39063bcc38
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Mon Dec 14 15:03:17 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d8660a4ab9a7e374d01c0028bf205c39063bcc38 [^]

Fixes issue 0011618 Fixes issue 0011464 Price adjustments fixed in requisitions to orders

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0022764)
rafaroda   
2009-12-14 16:19   
(edited on: 2010-01-08 17:38)
Steps to test this fix:
1) Create a Price Adjustment in Master Data Management || Pricing || Price Adjustments || Adjustments
* Name = Price Adjustment 40% off in all products for McGiver Supplies and Price List Purchase
* Starting Date = 01-01-2000
* Discount% = 40%
* Included Business Partners = All Selected
* Included Price Lists = All Selected
2) Navigate to Business Partner tab:
* Business Partner = McGiver Supplies
3) Navigate to Price List tab:
* Price List = Purchase
4) Create a new requisition in Procurement Management || Transactions || Requisition || Header
* Business Partner = McGiver Supplies
5) Navigate to Lines and create a new record:
* Product = Hammer
* Business Partner = Turtle Logistics
* Price List = Purchase
* Quantity = 65
* Unit Price = blank
* List Price = blank
* Discount = blank
6) Create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 15
* Unit Price = 4.50
* List Price = 5.00
* Discount = 10%
7) Create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 37
* Unit Price = blank
* List Price = blank
* Discount = blank
8) Navigate back to the requisition header and Complete it.
9) Navigate to Procurement Management || Transactions || Requisition To Order || Requisition To Order and Add the 3 former lines.
10) Set Price = 4.25 to line with Quantity = 65
11) Select all the lines, click on Create button, select McGiver Supplies as business partner (you have to select the business partner since the lines are for different vendors) and click on OK.
12) Navigate to the Purchase Order created.
13) Navigate to lines tab and check that:
* One line with Product = Hammer
** Quantity = 52 (37+15)
** Unit Price = 2.7 (Standard Price - Price Adjustment)
** Standard Price = 4.5
** Price Adjustment = 1.8 (Standard Price*40% = 4.5*40%)
** List Price = 5
** Discount = 10% ((List Price - Standard Price)*100/List Price)
* A second line with Product = Hammer
** Quantity = 65
** Unit Price = 2.55 (Standard Price - Price Adjustment)
** Standard Price = 4.25
** Price Adjustment = 1.7 (Standard Price*50% = 4.25*40%)
** List Price = 5
** Discount = 15% ((List Price - Standard Price)*100/List Price

See prices relations at https://issues.openbravo.com/view.php?id=8275 [^]
(0022803)
hudsonbot   
2009-12-15 08:58   
---
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d8660a4ab9a7 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15731.obx [^]
---
(0022829)
arunkumar   
2009-12-15 12:17   
Tested & Working fine
(0023044)
gorkaion   
2009-12-23 19:29   
wrong fix applied
(0023268)
hgbot   
2010-01-08 17:44   
Repository: erp/devel/pi
Changeset: 293034f2122236dbc3ebe8e178b7714a380735ba
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Fri Jan 08 14:16:31 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/293034f2122236dbc3ebe8e178b7714a380735ba [^]

Related to issue 11618. Related to issue 11464. Backed out previous fix.

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0023271)
hgbot   
2010-01-08 17:44   
Repository: erp/devel/pi
Changeset: 63e7d6c5520a8d2b6c0edfcd69ed42d55ce7f1ce
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Fri Jan 08 17:42:09 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/63e7d6c5520a8d2b6c0edfcd69ed42d55ce7f1ce [^]

Fixes issue 11618 Requisition To Order process has been fixed to calculate properly Price Adjustments defined for Price Lists.

---
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0023325)
sureshbabu   
2010-01-12 07:04   
Retested as per the steps mentioned in the issue id. Its working fine
(0023533)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/293034f21222 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]
(0023536)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/63e7d6c5520a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]