Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011576Openbravo ERPA. Platformpublic2009-12-01 15:522010-03-12 22:40
Reportershuehner 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP14 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011576: Improve handling of updating multiple modules at once if one of the module download fails
DescriptionIf you update multiple modules at the same time the sequence is:

1.) download first
2.) delete old first / unpack new first
3.) download second
4.) delete old second / unpack new second

When then i.e. the 'donwload second' fails with any error the first module is already deleted/updated which leave the system in a partially updated state.

If the first one is a core update this is even more ugly..
Steps To Reproducepre-requisite: mp8 + a commercial module which was changed in a later mp

Install i.e. mp8
install a commercial module from live cr
switch cr to staging system (via etc hosts change)
do not switch butler to staging system
scan for updates (should show mp9+update to the commercial module)
try to install update

first: core will be updated
second: module update will fail with invalid license (as staging-cr uses staging-butler, and local license is only for live-butler)
Proposed Solutiontwo possibilities:
a.) if a multiple module update includes core, do the core update at the end of the list
b.) first download all modules needed into temp-files. Only after all have been downloaded sucessfully start updating/unpacking them (safer against any kind of download errors).
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0012398 new dbaz Module download progress bar 
related to defect 0012292 closed alostale Add Module via Management Console (shows Error), but Module shows up as beeing installed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-01 15:52shuehnerNew Issue
2009-12-01 15:52shuehnerAssigned To => alostale
2010-01-05 12:10iciordiaStatusnew => acknowledged
2010-01-25 08:56alostalePrioritynormal => urgent
2010-01-25 08:56alostaleStatusacknowledged => scheduled
2010-01-25 08:56alostalefix_in_branch => pi
2010-02-22 08:23alostaleRelationship addedrelated to 0012292
2010-02-22 16:08alostaleRelationship addedrelated to 0012398
2010-03-04 16:00hgbotCheckin
2010-03-04 16:00hgbotNote Added: 0025057
2010-03-04 16:00hgbotStatusscheduled => resolved
2010-03-04 16:00hgbotResolutionopen => fixed
2010-03-04 16:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1feafe153e5eb06153fae5a183f698b3aee84a08 [^]
2010-03-09 21:04shuehnerNote Added: 0025198
2010-03-09 21:04shuehnerStatusresolved => closed
2010-03-09 21:04shuehnerFixed in Version => 2.50MP14
2010-03-10 17:20anonymoussf_bug_id0 =>
2010-03-10 18:28anonymoussf_bug_id => 2967949
2010-03-12 22:40hudsonbotCheckin
2010-03-12 22:40hudsonbotNote Added: 0025391

Notes
(0025057)
hgbot   
2010-03-04 16:00   
Repository: erp/devel/pi
Changeset: 1feafe153e5eb06153fae5a183f698b3aee84a08
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 04 15:34:33 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1feafe153e5eb06153fae5a183f698b3aee84a08 [^]

merge module install refactor, fixes issue 11576

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_InstallP2.html
M src/org/openbravo/erpCommon/modules/ImportModule.java
M src/org/openbravo/erpCommon/modules/ImportModule_data.xsql
M src/org/openbravo/erpCommon/modules/ModuleUtiltiy.java
A src/org/openbravo/erpCommon/modules/RemoteModule.java
---
(0025198)
shuehner   
2010-03-09 21:04   
Tested when reviewing the pi-module-install branch before merging it back into pi. Upgrading core worked fine without problems and a simulates download error (timeout by killing network connection) was noticed and shown to the user. This stopped the download process without touching the locally installed files.
(0025391)
hudsonbot   
2010-03-12 22:40   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1feafe153e5e [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]