Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011557Openbravo ERPE. Translationpublic2009-11-30 17:132010-01-21 00:00
Reportercarbonete 
Assigned Toiperdomo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target Version2.50MP11Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011557: Login error message hardcode
DescriptionIn case of login error message are harcoded in LoginHandler and not user Messages.
In case of localization its critical because most users not understand nothing in english. If i change this message it´s more one source to control. It´s not good.

thanks

Carbonete
Steps To Reproduceat login screen put incorret users and see message.
Proposed Solutionchange LoginHandler to use Messages table and one identifier to language of message.

Additional Information
TagsNo tags attached.
Relationships
related to defect 0012333 closed dbaz Clean browser's cache message should be translatable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-30 17:13carboneteNew Issue
2009-11-30 17:13carboneteAssigned To => rafaroda
2009-12-11 15:26rafarodaAssigned Torafaroda => iciordia
2009-12-11 17:51iperdomoNote Added: 0022717
2009-12-11 17:59iciordiaAssigned Toiciordia => iperdomo
2009-12-11 18:00iperdomoStatusnew => scheduled
2009-12-11 18:00iperdomofix_in_branch => pi
2009-12-11 18:00iperdomoOBNetwork customer => No
2009-12-11 18:00iperdomoTarget Version => 2.50MP11
2009-12-11 18:00iperdomofix_in_branchpi =>
2009-12-11 18:00iciordiaNote Added: 0022719
2009-12-11 18:58carboneteNote Added: 0022721
2009-12-11 18:58carboneteNote Added: 0022722
2009-12-30 17:03iperdomoNote Added: 0023159
2009-12-30 19:18hgbotCheckin
2009-12-30 19:18hgbotNote Added: 0023173
2009-12-30 19:18hgbotStatusscheduled => resolved
2009-12-30 19:18hgbotResolutionopen => fixed
2009-12-30 19:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8eca47561fe1f692ecc400d16381a8fd9df0268 [^]
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023525
2010-01-20 15:08alostaleStatusresolved => closed
2010-01-21 00:00anonymoussf_bug_id0 => 2935922
2010-02-18 11:36iperdomoRelationship addedrelated to 0012333

Notes
(0022717)
iperdomo   
2009-12-11 17:51   
The user language is only available after a successful log in. The LoginHandler only authenticates, but the session is filled with user preferences (language, role, etc) _after_ the authentication.
(0022719)
iciordia   
2009-12-11 18:00   
But still it makes sense to have a default language for the instance, and use that language when there is no language in the context
(0022721)
carbonete   
2009-12-11 18:58   
It´s possible detect primary browser language, example in php, but it´s a http header value.

thanks
(0022722)
carbonete   
2009-12-11 18:58   
My mistake http://techpatterns.com/downloads/php_language_detection.php [^] it´s detection example.
(0023159)
iperdomo   
2009-12-30 17:03   
The solution is to use the language defined in the System client.
(0023173)
hgbot   
2009-12-30 19:18   
Repository: erp/devel/pi
Changeset: e8eca47561fe1f692ecc400d16381a8fd9df0268
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Dec 30 19:18:32 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e8eca47561fe1f692ecc400d16381a8fd9df0268 [^]

Fixes issue 11557: Error login message is now based on System languange

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/base/secureApp/LoginHandler.java
---
(0023525)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/e8eca47561fe [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]