Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011529Openbravo ERPA. Platformpublic2009-11-27 13:372012-04-01 20:37
Reporteriperdomo 
Assigned Tomigueldejuana 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS10OS VersionXP
Product Version2.50MP7 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011529: Create columns process suggests wrong references
DescriptionCreate a table with a timestamp column and execute the process 'Create Columns from DB' ... The reference suggested is String and then the module validation fails:
+++++++++++++++++++++++++++++++++++++++++++++++++++
Errors for Validation type: WRONG_TYPE
+++++++++++++++++++++++++++++++++++++++++++++++++++
Column DBPREFIX_TABLE.TIMESTAMP_COLUMN has incorrect type, expecting VARCHAR NVARCHAR CHAR NCHAR CLOB but was TIMESTAMP

Also when using datatype eg. NUMERIC(10,3) .. A numeric value with decimal positions, the suggested reference is Integer that then is mapped to a Long java type.
Steps To Reproduce
Proposed SolutionSuggest:
* Date/DateTime for Timestamp
* Number for Numeric columns with decimal places
Additional Information
TagsOB3-Reviewed
Relationships
related to defect 0014777 closed migueldejuana Create columns from DB not working with columns of type text (PostgreSQL) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-27 13:37iperdomoNew Issue
2009-11-27 13:37iperdomoAssigned To => alostale
2009-11-27 13:37iperdomoOBNetwork customer => No
2009-11-27 13:41iperdomoSummaryCreate columns process suggests String when using timestamp as data type => Create columns process suggests wrong references
2009-11-27 13:41iperdomoDescription Updated
2009-11-27 13:41iperdomoSteps to Reproduce Updated
2010-01-05 12:13iciordiaPrioritynormal => urgent
2010-01-05 12:13iciordiaStatusnew => scheduled
2011-11-22 17:55alostaleNote Added: 0043089
2011-11-22 17:55alostaleTag Attached: OB3-Reviewed
2012-02-21 18:02alostaleAssigned Toalostale => migueldejuana
2012-02-29 11:36migueldejuanaRelationship addedrelated to 0014777
2012-03-06 18:11hgbotCheckin
2012-03-06 18:11hgbotNote Added: 0046103
2012-03-06 18:11hgbotStatusscheduled => resolved
2012-03-06 18:11hgbotResolutionopen => fixed
2012-03-06 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4fce66154b0fa6cc2810953fccbb817d5c7af1e [^]
2012-03-06 18:11alostaleNote Added: 0046104
2012-03-06 18:11alostaleStatusresolved => closed
2012-03-06 18:11alostaleFixed in Version => 3.0MP10
2012-04-01 20:37hudsonbotCheckin
2012-04-01 20:37hudsonbotNote Added: 0047050

Notes
(0043089)
alostale   
2011-11-22 17:55   
Tested in current pi:
-Timestamp is working as suggested
-NUMERIC(10,3) still proposing integer
(0046103)
hgbot   
2012-03-06 18:11   
Repository: erp/devel/pi
Changeset: a4fce66154b0fa6cc2810953fccbb817d5c7af1e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 29 12:51:09 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a4fce66154b0fa6cc2810953fccbb817d5c7af1e [^]

Fixed issue 11529: process 'Create Columns from DB' changed for Numeric suggestions

The 'Create Columns from DB' process suggested Numeric with the decimal as Integer, this is solved, now suggest Number reference. User_tab_columns have been changed in order to data scale column show the correct value.

---
M src-db/database/model/prescript-PostgreSql.sql
---
(0046104)
alostale   
2012-03-06 18:11   
Code review and tested on pi@a4fce66154b0
(0047050)
hudsonbot   
2012-04-01 20:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^]

Maturity status: Test