Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011512Openbravo ERP03. Procurement managementpublic2009-11-26 10:082010-01-20 23:26
Reportersureshbabu 
Assigned Torafaroda 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target Version2.50MP10Fixed in Version2.50MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011512: Invoice line net amount wrongly rounded of, while line item is created using the button create line from
DescriptionInvoice line net amount wrongly rounded off to the nearest whole number, when line item is created using the button "create line from"
Steps To ReproduceCreate and complete a purchase order of qty 5 and unit price 2.55
Create and complete goods receipt for the above created purchase order (qty = 5)

Navigate to Procurement Management || Transactions || Purchase Invoice || Header and click new, select the respective business partner
and click create lines from button and in Shipment/Receipt field select the above created Receipt

Receipt details will be displayed, check the check box and click OK button

Process completed message appears, move to line tab and click the line item in form view and verify the Line Net amount, it appears as 13.00 instead of 12.75



Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00115112.50MP11 closed harikrishnan Invoice amount wrongly calculated when invoice is created by Generate invoice from receipt button 
related to defect 0010130 closed harikrishnan The discounts are not correctly copied when using create lines from in the invoice window 
related to defect 00119432.50MP11 closed harikrishnan the quantity of line is rounded when it is created by "create from lines" in goods receipt 
Attached Filesjpg invoice amount wrongly rounded.JPG (161,539) 2009-11-26 10:08
https://issues.openbravo.com/file_download.php?file_id=1987&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2009-11-26 10:08sureshbabuNew Issue
2009-11-26 10:08sureshbabuFile Added: invoice amount wrongly rounded.JPG
2009-11-26 11:35sureshbabuProject@27@ => Openbravo ERP
2009-11-26 11:36sureshbabuCategoryQuickStart Template + Datasets => 03. Procurement management
2009-11-26 12:08psarobeAssigned To => rafaroda
2009-11-26 12:08psarobePriorityurgent => immediate
2009-11-26 12:08psarobeStatusnew => scheduled
2009-11-26 12:08psarobeversion => 2.50MP8
2009-11-26 12:08psarobeversion2.50MP8 => main
2009-11-26 13:54psarobeTarget Version => 2.50MP10
2009-11-27 06:04sureshbabuNote Added: 0022215
2009-12-15 15:42rafarodaRelationship addedrelated to 0011511
2010-01-04 10:59dvpsonNote Added: 0023187
2010-01-11 09:43rafarodaRelationship addedrelated to 0010130
2010-01-12 18:09rafarodaRelationship addedrelated to 0011943
2010-01-12 18:19psarobeRelationship replacedhas duplicate 0011943
2010-01-12 18:44psarobeRelationship replacedrelated to 0011943
2010-01-17 19:02hgbotCheckin
2010-01-17 19:02hgbotNote Added: 0023483
2010-01-17 19:02hgbotStatusscheduled => resolved
2010-01-17 19:02hgbotResolutionopen => fixed
2010-01-17 19:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/520829d243f7953887e57a24f8a9be589771eae8 [^]
2010-01-18 12:45sureshbabuNote Added: 0023501
2010-01-18 12:45sureshbabuStatusresolved => closed
2010-01-18 12:45sureshbabuFixed in Version => 2.50MP10
2010-01-18 12:52sureshbabuFixed in Version2.50MP10 => 2.50MP11
2010-01-19 00:00anonymoussf_bug_id0 => 2934607
2010-01-20 23:26hudsonbotCheckin
2010-01-20 23:26hudsonbotNote Added: 0023662

Notes
(0022215)
sureshbabu   
2009-11-27 06:04   
Rafa,
Yesterday, Pablo done a code review regarding this issue and identified that the Precision value is taken from UOM(in this case the UOM is Bag and by default the precision value is set to Zero). So today morning i changed the Precision value for Bag from Zero(0) to Two, then i tried to reproduce the issue and the invoice amount is rightly calculated.

And also Pablo suggested that instead of picking the precision value from UOM, it would be appropriate if the value is taken from currency.

We would like to hear your thoughts on this.

Thanks
Suresh
(0023187)
dvpson   
2010-01-04 10:59   
Should this not be maintained in the Price Lists Schema, as there is the List, standard and price limit rounding. So when the values are calculated it should conform with those parameters.

Regards

David
(0023483)
hgbot   
2010-01-17 19:02   
Repository: erp/devel/pi
Changeset: 520829d243f7953887e57a24f8a9be589771eae8
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Sun Jan 17 15:23:28 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/520829d243f7953887e57a24f8a9be589771eae8 [^]

Fixes issue 11512 \"Create Lines From\" in Invoice window now rounds correctly when selecting a Shipment.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0023501)
sureshbabu   
2010-01-18 12:45   
Tested working fine(tested in PI)
(0023662)
hudsonbot   
2010-01-20 23:26   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/520829d243f7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/fa6621f85351 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15942.obx [^]