Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011464Openbravo ERP03. Procurement managementpublic2009-11-23 15:472010-01-19 01:41
Reporternetworkb 
Assigned Togorkaion 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP8 
Target Version2.50MP11Fixed in Version2.50MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011464: Error when Create Purchase Order from a Requisition
DescriptionWhen yo try create the purchase order appears this Error:

Error:
no existe la funcion m_get_offers_price(timestamp without time zone, character
varying, character varying, numeric, numeric, numeric)
Steps To Reproduce-As Openbravo Admin go to Procurement Management || Transactions || Requisition
-Create a new record
-Save and go to Lines.
-Product: Hammer
-Save, go to the Header and Complete
-Go to Procurement Management || Transactions || Manage Requisitions
-Chose the Requisition created after filtering
-Click Create Purchase Order
Proposed SolutionReview M_REQUISITION_CREATE_PO function in the following line https://code.openbravo.com/erp/devel/pi/file/882e0f7a9b8f/src-db/database/model/functions/M_REQUISITION_CREATEPO.xml#l222 [^]

It is using variable v_PriceList NUMBER (which is the price defined as price list - WRONG) instead of Cur_Lines.PriceList_ID (which is the ID of the pricelist- CORRECT).

M_GET_OFFERS_PRICE gets the ID of a pricelist (VARCHAR2(32)) as last parameter, which is also CORRECT https://code.openbravo.com/erp/devel/pi/file/18ebb927b0fe/src-db/database/model/functions/M_GET_OFFERS_PRICE.xml [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0011765 closed gorkaion Error when Create Purchase Order from a Requisition 
related to defect 00116182.40MP12 closed gorkaion the price adjustment isn't correct if in the price adustment includes a Price List 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-23 15:47networkbNew Issue
2009-11-23 15:47networkbAssigned To => rafaroda
2009-11-23 17:33rafarodaPriorityimmediate => high
2009-11-23 17:33rafarodaStatusnew => scheduled
2009-11-23 17:33rafarodaProposed Solution updated
2009-11-23 17:33rafarodaSteps to Reproduce Updated
2009-12-14 12:28rafarodaRelationship addedrelated to 0011618
2009-12-14 12:46rafarodaSteps to Reproduce Updated
2009-12-14 12:46rafarodaIssue cloned0011765
2009-12-14 12:46rafarodaRelationship addeddepends on 0011765
2009-12-14 16:18hgbotCheckin
2009-12-14 16:18hgbotNote Added: 0022763
2009-12-14 16:18hgbotStatusscheduled => resolved
2009-12-14 16:18hgbotResolutionopen => fixed
2009-12-14 16:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d8660a4ab9a7e374d01c0028bf205c39063bcc38 [^]
2009-12-14 16:20rafarodaNote Added: 0022765
2009-12-15 08:58hudsonbotCheckin
2009-12-15 08:58hudsonbotNote Added: 0022804
2009-12-15 11:34arunkumarNote Added: 0022819
2009-12-15 11:34arunkumarStatusresolved => closed
2009-12-15 11:34arunkumarFixed in Version => 2.50MP10
2009-12-16 00:00anonymoussf_bug_id0 => 2915145
2009-12-23 19:29gorkaionAssigned Torafaroda => gorkaion
2009-12-23 19:29gorkaionNote Added: 0023045
2009-12-23 19:29gorkaionStatusclosed => new
2009-12-23 19:29gorkaionResolutionfixed => open
2009-12-23 19:29gorkaionFixed in Version2.50MP10 =>
2009-12-30 19:00psarobeStatusnew => scheduled
2009-12-30 19:00psarobefix_in_branch => pi
2010-01-08 15:13rafarodaNote Edited: 0022765
2010-01-08 16:43rafarodaNote Edited: 0022765
2010-01-08 17:44hgbotCheckin
2010-01-08 17:44hgbotNote Added: 0023269
2010-01-08 17:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d8660a4ab9a7e374d01c0028bf205c39063bcc38 [^] => http://code.openbravo.com/erp/devel/pi/rev/293034f2122236dbc3ebe8e178b7714a380735ba [^]
2010-01-08 17:44hgbotCheckin
2010-01-08 17:44hgbotNote Added: 0023270
2010-01-08 17:44hgbotStatusscheduled => resolved
2010-01-08 17:44hgbotResolutionopen => fixed
2010-01-08 17:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/293034f2122236dbc3ebe8e178b7714a380735ba [^] => http://code.openbravo.com/erp/devel/pi/rev/35251d20ffb1146f3571a9b9c794ac11a75bfe86 [^]
2010-01-12 09:43sureshbabuNote Added: 0023330
2010-01-12 09:43sureshbabuStatusresolved => closed
2010-01-12 09:43sureshbabuFixed in Version => 2.50MP10
2010-01-18 11:58sureshbabuFixed in Version2.50MP10 => 2.50MP11
2010-01-18 11:58sureshbabufix_in_branchpi =>
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023534
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023535

Notes
(0022763)
hgbot   
2009-12-14 16:18   
Repository: erp/devel/pi
Changeset: d8660a4ab9a7e374d01c0028bf205c39063bcc38
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Mon Dec 14 15:03:17 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d8660a4ab9a7e374d01c0028bf205c39063bcc38 [^]

Fixes issue 0011618 Fixes issue 0011464 Price adjustments fixed in requisitions to orders

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0022765)
rafaroda   
2009-12-14 16:20   
(edited on: 2010-01-08 16:43)
Steps to test this fix:
1) Create a Price Adjustment in Master Data Management || Pricing || Price Adjustments || Adjustments
* Name = Price Adjustment 40% off in all products for McGiver Supplies and Price List Purchase
* Starting Date = 01-01-2000
* Discount% = 40%
* Included Business Partners = All Selected
* Included Price Lists = All Selected
2) Navigate to Business Partner tab:
* Business Partner = McGiver Supplies
3) Navigate to Price List tab:
* Price List = Purchase
4) Create a new requisition in Procurement Management || Transactions || Requisition || Header
* Business Partner = McGiver Supplies
5) Navigate to Lines and create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 15
* Unit Price = 4.50
* List Price = 5.00
* Discount = 10%
6) Create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 37
* Unit Price = blank
* List Price = blank
* Discount = blank
7) Create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 65
* Unit Price = 4.25
* List Price = 5.00
* Discount = 15%
8) Navigate back to the requisition header and Complete it.
9) Navigate to Procurement Management || Transactions || Manage Requisitions || Header and select the previous requisition.
10) Click on Create Purchase Order and select an Order Date, Business Partner = McGiver Supplies, Price List = Purchase and click on OK.
11) Navigate to the Purchase Order created.
12) Navigate to lines tab and check that:
* One line with Product = Hammer
** Quantity = 37
** Unit Price = 2.7 (Standard Price - Price Adjustment)
** Standard Price = 4.5
** Price Adjustment = 1.8 (Standard Price*40% = 4.5*40%)
** List Price = 5
** Discount = 10% ((List Price - Standard Price)*100/List Price)
* A second line with Product = Hammer
** Quantity = 15
** Unit Price = 2.7 (Standard Price - Price Adjustment)
** Standard Price = 4.5
** Price Adjustment = 1.8 (Standard Price*40% = 4.5*40%)
** List Price = 5
** Discount = 10% ((List Price - Standard Price)*100/List Price
* A third line with Product = Hammer
** Quantity = 65
** Unit Price = 2.55 (Standard Price - Price Adjustment)
** Standard Price = 4.25
** Price Adjustment = 1.7 (Standard Price*50% = 4.25*40%)
** List Price = 5
** Discount = 15% ((List Price - Standard Price)*100/List Price

See prices relations at https://issues.openbravo.com/view.php?id=8275 [^]
(0022804)
hudsonbot   
2009-12-15 08:58   
---
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d8660a4ab9a7 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15731.obx [^]
---
(0022819)
arunkumar   
2009-12-15 11:34   
Tested & working fine
(0023045)
gorkaion   
2009-12-23 19:29   
wrong fix applied
(0023269)
hgbot   
2010-01-08 17:44   
Repository: erp/devel/pi
Changeset: 293034f2122236dbc3ebe8e178b7714a380735ba
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Fri Jan 08 14:16:31 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/293034f2122236dbc3ebe8e178b7714a380735ba [^]

Related to issue 11618. Related to issue 11464. Backed out previous fix.

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0023270)
hgbot   
2010-01-08 17:44   
Repository: erp/devel/pi
Changeset: 35251d20ffb1146f3571a9b9c794ac11a75bfe86
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Fri Jan 08 17:16:38 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/35251d20ffb1146f3571a9b9c794ac11a75bfe86 [^]

Fixes issue 11464 Fixed M_REQUISITION_CREATEPO in order to properly calculate price adjustments and discounts.

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
---
(0023330)
sureshbabu   
2010-01-12 09:43   
Tested, able to create purchase order from requisition.
(0023534)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/293034f21222 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]
(0023535)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/35251d20ffb1 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]