Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011411Openbravo ERP00. Application dictionarypublic2009-11-19 10:442012-04-26 19:32
Reportermirurita 
Assigned Todmiguelez 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Versionmain 
Target VersionFixed in Version3.0MP12 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011411: FacAcctType column of Fact_Acct table does not have a correct reference
DescriptionFacAcctType column has YesNo reference and it can take the following values:
O: Open
N: Normal
C: Close
R: Regularization
Steps To Reproduce
- Login as System Administrator
- Go to Application Dictionary || Tables and Columns
- Search for FinancialMgmtAccountingFact
- Go to Column tab and select FactAcctType column
Proposed Solution
Additional Information
TagsOB3-Reviewed, VMA-Reviewed
Relationships
related to defect 0020327 closed dmiguelez API Change in FACT_ACCT.FACTACCTTYPE 
related to defect 0019802 closed mirurita The GL Journal entries flag as "Opening" are not taken into account as "Opening" while launching the General ledger Journal 
blocks defect 0020321 closed dmiguelez Wrong demo data info for closing entries 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-19 10:44miruritaNew Issue
2009-11-19 10:44miruritaAssigned To => rafaroda
2010-02-11 18:34rafarodaAssigned Torafaroda => dalsasua
2010-08-19 19:46elopioNote Added: 0030163
2010-08-19 19:47XPandIT_martinsIssue Monitored: XPandIT_martins
2010-08-19 19:48Xpand-ITIssue Monitored: Xpand-IT
2010-08-20 10:04dalsasuaNote Added: 0030174
2011-07-20 18:17dalsasuaAssigned Todalsasua => jonalegriaesarte
2011-11-25 17:46jonalegriaesarteTag Attached: OB3-Reviewed
2012-04-03 12:20jonalegriaesarteAssigned Tojonalegriaesarte => vmromanos
2012-04-10 17:23vmromanosTag Attached: VMA-Reviewed
2012-04-16 16:28dmiguelezAssigned Tovmromanos => dmiguelez
2012-04-16 16:28dmiguelezStatusnew => scheduled
2012-04-16 16:28dmiguelezfix_in_branch => pi
2012-04-17 09:38dmiguelezNote Added: 0047654
2012-04-20 11:48eduardo_ArgalRelationship addedblocks 0020321
2012-04-23 13:11dmiguelezRelationship addedrelated to 0020327
2012-04-25 18:09dmiguelezNote Added: 0047971
2012-04-25 18:13hgbotCheckin
2012-04-25 18:13hgbotNote Added: 0047973
2012-04-25 18:13hgbotStatusscheduled => resolved
2012-04-25 18:13hgbotResolutionopen => fixed
2012-04-25 18:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c8a9f6fc04d63f263196f075eccf8a0af804004e [^]
2012-04-25 21:35hgbotCheckin
2012-04-25 21:35hgbotNote Added: 0047984
2012-04-26 09:52miruritaNote Added: 0047989
2012-04-26 09:52miruritaStatusresolved => closed
2012-04-26 09:52miruritaFixed in Version => 3.0MP12
2012-04-26 19:32hudsonbotCheckin
2012-04-26 19:32hudsonbotNote Added: 0048100
2012-04-26 19:32hudsonbotCheckin
2012-04-26 19:32hudsonbotNote Added: 0048105
2012-05-28 12:39naiaramartinezRelationship addedrelated to 0019802

Notes
(0030163)
elopio   
2010-08-19 19:46   
This was pointed out by martins_XpandIT on IRC today.

Could you explain what's the problem and the possible solution here?
The column should allow 4 values?
Or the documentation should refer only to 2 values?
(0030174)
dalsasua   
2010-08-20 10:04   
Reference is not correct: all those 4 values must be allowed.
(0047654)
dmiguelez   
2012-04-17 09:38   
Fixing this issue creates an Api change:


org.openbravo.dal.xml:
Missing
method org.openbravo.dal.xml.StaxXMLEntityConverter.newInstance(): missing in /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/test
method org.openbravo.dal.xml.XMLEntityConverter.newInstance(): missing in /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/test

org.openbravo.model.financialmgmt.accounting:
Missing
method org.openbravo.model.financialmgmt.accounting.AccountingFact.isType(): missing in /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/test
method org.openbravo.model.financialmgmt.accounting.AccountingFact.setType(java.lang.Boolean): missing in /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/test

org.openbravo.service.db:
Missing
method org.openbravo.service.db.ClientImportEntityResolver.getInstance(): missing in /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/test
(0047971)
dmiguelez   
2012-04-25 18:09   
Login as Openbravo/openbravo

Change rol to System Administrator.
Go to Tables and Columns.
Select the row with DB Table Name:
Fact_Acct.
Move to Column.
Select the row with DB Table Name:
factaccttype
Realize that the Reference is now a List.
By drilling down through the Reference Search Key, realize that the list exists and has four entries in the List Reference Tab.
(0047973)
hgbot   
2012-04-25 18:13   
Repository: erp/devel/pi
Changeset: c8a9f6fc04d63f263196f075eccf8a0af804004e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Apr 25 18:01:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c8a9f6fc04d63f263196f075eccf8a0af804004e [^]

Fixes issue 11411: Changed a yes/no reference to a list reference.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/model/tables/FACT_ACCT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0047984)
hgbot   
2012-04-25 21:35   
Repository: erp/devel/pi
Changeset: 86fe6f8c5c295a198886acea6023ed7a41a911fa
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Apr 25 20:29:57 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/86fe6f8c5c295a198886acea6023ed7a41a911fa [^]

Related to issue 0011411: Changes false for N so it can work with
API change.

---
M referencedata/sampledata/F_B_International_Group.xml
M referencedata/sampledata/QA_Testing.xml
---
(0047989)
mirurita   
2012-04-26 09:52   
code review + testing OK

FactAcctType column is a List containing the following values
N: Normal
C: Close
R: Regularization
O: Open

Physical definition of the column has been changed to VARCHAR(60)

AD view (using FactAcctType column) columns length changed to 60
(0048100)
hudsonbot   
2012-04-26 19:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/70a717a9ffa1 [^]

Maturity status: Test
(0048105)
hudsonbot   
2012-04-26 19:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/70a717a9ffa1 [^]

Maturity status: Test