Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011349Openbravo ERP00. Application dictionarypublic2009-11-13 10:562010-01-19 01:41
Reporternetworkb 
Assigned Toiperdomo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP8 
Target Version2.50MP11Fixed in Version2.50MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011349: The register menu entrie is showed for all the users in the application
DescriptionThe register menu entrie is showed for all the users in the application.
If you don't want a user to see it, you are not able do hide it.


Steps To Reproduce-Create a new role with access only to a window
-Create a user and assign to this role
-Access to the appliccation with this new user.
See that the following entri is showed:
General Setup > Application > Register
Proposed SolutionProposal is to delete the registration link. You already have a flow for the System Administrator to register your instance. To be approved by PJU
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0007472 closed iperdomo I can see General Setup > Application > Register with a role that has only Sales Module access 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-13 10:56networkbNew Issue
2009-11-13 10:56networkbAssigned To => rafaroda
2009-11-16 11:01rafarodaNote Added: 0021841
2009-11-16 11:01rafarodaAssigned Torafaroda => iperdomo
2009-11-16 11:01rafarodaPriorityimmediate => high
2009-11-16 11:01rafarodaStatusnew => scheduled
2009-11-16 11:02rafarodaRelationship addedhas duplicate 0007472
2009-12-09 14:12iperdomoNote Added: 0022587
2009-12-09 14:12iperdomoStatusscheduled => feedback
2009-12-10 11:24iperdomoNote Added: 0022614
2009-12-14 11:23rafarodaNote Added: 0022737
2009-12-14 11:34networkbNote Added: 0022739
2009-12-14 11:34networkbStatusfeedback => new
2009-12-14 11:51rafarodaStatusnew => scheduled
2009-12-14 11:51rafarodaSteps to Reproduce Updated
2009-12-14 11:52rafarodaIssue Monitored: pjuvara
2009-12-14 11:52rafarodaNote Added: 0022741
2009-12-29 17:27iperdomoNote Added: 0023143
2009-12-29 19:47hgbotCheckin
2009-12-29 19:47hgbotNote Added: 0023146
2009-12-29 19:47hgbotStatusscheduled => resolved
2009-12-29 19:47hgbotResolutionopen => fixed
2009-12-29 19:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/07874ad44f9fbd1ce4ebca3753b6460729195ba7 [^]
2009-12-30 07:44arunkumarNote Added: 0023151
2009-12-30 07:44arunkumarStatusresolved => closed
2009-12-30 07:44arunkumarFixed in Version => 2.50MP10
2009-12-30 17:02hgbotCheckin
2009-12-30 17:02hgbotNote Added: 0023157
2009-12-30 17:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/07874ad44f9fbd1ce4ebca3753b6460729195ba7 [^] => http://code.openbravo.com/erp/devel/pi/rev/9ad8577526a42c002257f93f10f1ac3c0aa5de38 [^]
2009-12-31 00:00anonymoussf_bug_id0 => 2923859
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023521
2010-01-19 01:41hudsonbotCheckin
2010-01-19 01:41hudsonbotNote Added: 0023523

Notes
(0021841)
rafaroda   
2009-11-16 11:01   
Ideally, the Register link should only display for System Administrators in Openbravo ERP instances not registered yet.
(0022587)
iperdomo   
2009-12-09 14:12   
The links doesn't have access level property, therefore you cannot define which roles have access to a link. Adding access level to links is a feature request.

My proposal is to delete the registration link. You already have a flow for the System Administrator to register your instance.
(0022614)
iperdomo   
2009-12-10 11:24   
The current registration pop-up window appends the instance_id when opening the registration form in Openbravo's website (see requirement 1.6 [1]) that's not possible with menu links, so if someone uses the link in the menu, the instance id is not appended and we loose this capability.

[1] http://wiki.openbravo.com/wiki/Projects/Require_Heartbeat_in_Module_Management_Console/Functional_Specification#Functional_requirements_based_on_business_processes [^]
(0022737)
rafaroda   
2009-12-14 11:23   
Reminder sent to: networkb

Can you please comment on the solution proposed?

Thanks.
(0022739)
networkb   
2009-12-14 11:34   
Deleting the registration link is a good solution if you can go throw other window to this process.
(0022741)
rafaroda   
2009-12-14 11:52   
Reminder sent to: pjuvara

Paolo,

Based on the Notes of this issue, can you please comment on the solution proposed?

Thanks.
(0023143)
iperdomo   
2009-12-29 17:27   
The issue will be solved by replacing the link with a manual form only visible to System Administrator role.
(0023146)
hgbot   
2009-12-29 19:47   
Repository: erp/devel/pi
Changeset: 07874ad44f9fbd1ce4ebca3753b6460729195ba7
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Dec 29 19:45:43 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/07874ad44f9fbd1ce4ebca3753b6460729195ba7 [^]

Fixes issue 11349: Changed way to open registration form
-Now the Registration menu entry is only shown to Sys Admin
-Clicking the menu entry shows the 'home' window

---
M src-db/database/model/postscript-Oracle.sql
M src-db/database/model/postscript-PostgreSql.sql
M src-db/database/sourcedata/AD_FORM.xml
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src/org/openbravo/erpCommon/utility/Home.html
M src/org/openbravo/erpCommon/utility/Home.xml
A src/org/openbravo/erpCommon/utility/Register.java
---
(0023151)
arunkumar   
2009-12-30 07:44   
Now the Registration menu entry is only shown to Sys Admin. Tested & Working fine.
(0023157)
hgbot   
2009-12-30 17:02   
Repository: erp/devel/pi
Changeset: 9ad8577526a42c002257f93f10f1ac3c0aa5de38
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Dec 30 13:38:34 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9ad8577526a42c002257f93f10f1ac3c0aa5de38 [^]

Fixes double declaration of variables. Related to issue 11349

---
M src/org/openbravo/erpCommon/utility/VerticalMenu.html
---
(0023521)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/07874ad44f9f [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]
(0023523)
hudsonbot   
2010-01-19 01:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/9ad8577526a4 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7f3a35240cf9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15846.obx [^]