0011310: Empty invoice line when creating invoice (Create Invoices from Orders process)

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0011310

Openbravo ERP

07. Sales management

public

2009-11-11 09:50

2010-10-19 00:00

Reporter

neil_smith

Assigned To

adrianromero

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

2.50

Target Version

2.50MP24

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0011310: Empty invoice line when creating invoice (Create Invoices from Orders process)

Description

An empty line (no description, quantity and price = 0) is generated when creating invoices in the 'Create Invoices from Orders' process if the Invoice Terms is set to 'Customer Schedule after Delivery'.
This is not related to the 8070 bug.

Steps To Reproduce

1. Create an order for a customer that has an invoice term set to 'Customer Schedule after Delivery'
2. Post the document
3. Create the shipment
4. Generate the invoice ('Create Invoices from Orders' process)

In the created invoice, there is an empty line in the invoice (the first line).

If the invoice regroups more than one order, there is an empty line at the beginning of each invoiced order.

It is the reference to the shipment that is not created properly.

Proposed Solution

The problem is in the c_invoice_create(IN p_pinstance_id character varying, OUT p_invoice_id character varying, IN p_order_id character varying) function.
At the line 964 (v_Reference:=v_Reference || ': ' || Cur_InvoiceSchedule.Description;)
If the description of the shipment is empty (NULL), v_Reference is also set to NULL (reminder : something concat to null = null!).
There should be a test before the concatenation, checking if the description of the shipment header is not null (IF (Cur_InvoiceSchedule.Description IS NOT NULL) THEN).
Like that, it is only concatenated if the description is not null.

As a workaround, when the order is created, a description is entered on the header, it is automatically copied on the shipment (if the 'Create Shipments from Orders' process is used), so it is not null. Or one can manually enter the description on the shipment.

Additional Information