Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0011196 | Openbravo ERP | 01. General setup | public | 2009-10-30 16:32 | 2009-11-18 00:00 |
|
| Reporter | networkb | |
| Assigned To | rafaroda | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 2.50MP6 | |
| Target Version | 2.50MP10 | Fixed in Version | 2.50MP9 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0011196: A confusing message error is shown in User window |
| Description | If you fill in First name a value with more than 60 characters and a Last name with more than 60 characters, and you try to save it, this message appears:
ERROR: el valor es demasiado largo para el tipo character varying(60)
(in Spanish, when english is used)
Message does not say what field is too long. |
| Steps To Reproduce | Go to General Setup > Security > User.
Create a new one.
In First name enter a value about 40 characters.
In Last name enter a value about 40 characters.
Try to save it. |
| Proposed Solution | To fix that the callout doing this concatenation (SL_User_Name) should be improved to either shorten the concatenated name with a warning/info message. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2009-10-30 16:32 | networkb | New Issue | |
| 2009-10-30 16:32 | networkb | Assigned To | => rafaroda |
| 2009-11-02 05:55 | rafaroda | Note Added: 0021497 | |
| 2009-11-02 05:55 | rafaroda | Assigned To | rafaroda => shuehner |
| 2009-11-02 05:55 | rafaroda | Status | new => acknowledged |
| 2009-11-02 15:02 | shuehner | Note Added: 0021507 | |
| 2009-11-02 15:09 | rafaroda | Assigned To | shuehner => rafaroda |
| 2009-11-02 15:09 | rafaroda | Status | acknowledged => scheduled |
| 2009-11-02 15:09 | rafaroda | Steps to Reproduce Updated | |
| 2009-11-02 15:10 | rafaroda | Note Added: 0021508 | |
| 2009-11-02 15:10 | rafaroda | Status | scheduled => feedback |
| 2009-11-02 16:05 | networkb | Note Added: 0021511 | |
| 2009-11-02 16:05 | networkb | Status | feedback => new |
| 2009-11-03 08:24 | rafaroda | Priority | immediate => high |
| 2009-11-03 08:24 | rafaroda | Status | new => scheduled |
| 2009-11-03 08:24 | rafaroda | Steps to Reproduce Updated | |
| 2009-11-16 19:30 | hgbot | Checkin | |
| 2009-11-16 19:30 | hgbot | Note Added: 0021888 | |
| 2009-11-16 19:30 | hgbot | Status | scheduled => resolved |
| 2009-11-16 19:30 | hgbot | Resolution | open => fixed |
| 2009-11-16 19:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1ac1162e77d90b5948509bff758ebbafb3d29c7e [^] |
| 2009-11-16 19:34 | rafaroda | Note Added: 0021889 | |
| 2009-11-17 05:37 | sureshbabu | Note Added: 0021891 | |
| 2009-11-17 05:37 | sureshbabu | Status | resolved => closed |
| 2009-11-17 05:37 | sureshbabu | Fixed in Version | => 2.50MP9 |
| 2009-11-18 00:00 | anonymous | sf_bug_id | 0 => 2899460 |
|
Notes |
|
|
|
Stefan,
Can you please comment about the database language displaying the error messages?
Thanks. |
|
|
|
|
The string displayed comes directly from the database system in whatever language was specified for error messages in the database server.
In general it is impossible (meaning effort/gain) to provide a translation system for every possible dbms error message type.
However, in this case we should fix the ERP to not insert the too long value in the first place.
The name & username (both 60 chars) are created based on firstname + ' ' + lastname (also both 60 chars) so an overflow can easily happen as described here.
To fix that the callout doing this concatenation (SL_User_Name) should be improved to either perhaps shorten the concatenated name with a warning/info message. |
|
|
|
|
Can you please comment if the proposed solution fits your needs?
Thanks. |
|
|
|
|
|
A warning/info message would be a proper solution |
|
|
|
(0021888)
|
|
hgbot
|
|
2009-11-16 19:30
|
|
Repository: erp/devel/pi
Changeset: 1ac1162e77d90b5948509bff758ebbafb3d29c7e
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Thu Nov 12 04:25:24 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1ac1162e77d90b5948509bff758ebbafb3d29c7e [^]
Fixes issue 11196 Now Name and Username fields are cut to fit their fields length.
---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java
---
|
|
|
|
|
In order to test this fix:
1) Go to General Setup || Security || User
* Type First Name until the end
* Type Last Name until the end: "Name and Username have been cut to fit field length." message displays.
* Remove Last Name field data: message is cleared.
* Cut First Name to 4 characters.
* Type 4 characters for Last Name
* Type Last Name until the end: "Name and Username have been cut to fit field length." message displays. |
|
|
|
|
|
Tested working as per Rafa comments |
|