Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0011146Openbravo ERP07. Sales managementpublic2009-10-27 10:182009-11-14 00:00
networkb 
harikrishnan 
highmajoralways
closedfixed 
5
2.35MP15 
2.35MP162.50MP9 
Core
No
0011146: Process "Create Lines From" invoices doesn't have into account the Invoice terms set
For example, you have a completed Sales Order with InvoiceTerms= after delivery. Then you make a new Sales Invoice by selecting the order with "create lines from" button.

You should not be able to create an invoice because with this kind of InvoiceTerms you should have the Shipment in the system and you haven't.
1. Sales Management || Transactions || Sales Order: create new record with InvoiceTerms=after delivery. Complete.
2. Sales Management || Transactions || Sales Invoice: create new record for same business partner and "Create Lines From" choosing the sales order.

You are able to create an invoice for a Sales Order "after delivery" without shipment created.
No tags attached.
related to defect 0010063 closed harikrishnan Do not invoice invoice term are not resepected 
depends on backport 00111532.35MP16 closed harikrishnan Process "Create Lines From" invoices doesn't have into account the Invoice terms set 
depends on backport 00111542.35MP16 closed harikrishnan Process "Create Lines From" invoices doesn't have into account the Invoice terms set 
png Order.png (89,846) 2009-10-27 14:45
https://issues.openbravo.com/file_download.php?file_id=1888&type=bug
png

png CreateLinesFromInvoice.png (23,620) 2009-10-27 14:45
https://issues.openbravo.com/file_download.php?file_id=1889&type=bug
png
Issue History
2009-10-27 10:18networkbNew Issue
2009-10-27 10:18networkbAssigned To => rafaroda
2009-10-27 14:39rafarodaNote Added: 0021428
2009-10-27 14:39rafarodaStatusnew => feedback
2009-10-27 14:45rafarodaFile Added: Order.png
2009-10-27 14:45rafarodaFile Added: CreateLinesFromInvoice.png
2009-10-27 17:31networkbNote Added: 0021429
2009-10-27 17:32networkbStatusfeedback => new
2009-10-28 06:17rafarodaNote Added: 0021433
2009-10-28 06:17rafarodaStatusnew => feedback
2009-10-28 08:57psarobeNote Added: 0021434
2009-10-28 08:58psarobePriorityimmediate => high
2009-10-28 08:58psarobeStatusfeedback => scheduled
2009-10-28 08:58psarobefix_in_branch => pi
2009-11-10 08:05harikrishnanAssigned Torafaroda => harikrishnan
2009-11-12 06:25harikrishnanRelationship addedrelated to 0010063
2009-11-12 06:27harikrishnanNote Added: 0021747
2009-11-12 06:40hgbotCheckin
2009-11-12 06:40hgbotNote Added: 0021751
2009-11-12 06:40hgbotStatusscheduled => resolved
2009-11-12 06:40hgbotResolutionopen => fixed
2009-11-12 06:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b6d1c51cb38ad723f4e4cd68f8eb2ca58c5e14a [^]
2009-11-13 11:54arunkumarNote Added: 0021809
2009-11-13 11:54arunkumarStatusresolved => closed
2009-11-13 11:54arunkumarFixed in Version => 2.50MP9
2009-11-14 00:00anonymoussf_bug_id0 => 2897491

Notes
(0021428)
rafaroda   
2009-10-27 14:39   
Not able to reproduce this issue, please see attached screenshots.

Can you please provide further information?

Thanks.
(0021429)
networkb   
2009-10-27 17:31   
Hi,

That is the problem: that you can choose the order (set as invoiced after delivery) when you have not shipment created.

If "Create Lines from" would have invoice terms into consideration you should not be able to create an Invoice from this order without having a shipment.

Regards
(0021433)
rafaroda   
2009-10-28 06:17   
Please notice that the document number of the order of Order.png is not the same that document number in the combobox of CreateLinesFrom.png.

Order created and completed with invoice terms = after delivery does not appear in that combobox if shipment has not been created.
(0021434)
psarobe   
2009-10-28 08:57   
Hi,

I got the point. It seems that if it is "After delivery" Rafa is right and is working perfectly.

The problem is when the invoice terms is "Customer schedule after delivery" that is not taking into account this condition.
My concern is that maybe is not taking into account the rest of the invoice terms:
1. "After order delivery": Only when the whole sales order is completely delivered it will be in the drop down list
2. "not invoice": In this case the sales order shouldn't be present in the combo box
3. "Customer schedule after delivery": The same logic as After delivery
(0021747)
harikrishnan   
2009-11-12 06:27   
Test Case.


1.Create a new sales order (Sales Management || Transactions || Sales Order) with following "After Delivery" Invoice Terms.

  Definition for "After Delivery" Invoice Term :
      In this case the customer will be invoiced for the goods that have been delivered
  Header
      *Invoice Terms=After Delivery.
      *Business Partner = mcgiver
  Line
      *Create two lines for product A & B
        #Product A=5
         #Product B=3
  Complete the sales order.
  Now go to Goods Shipment (Sales Management || Transactions || Goods Shipment || Header) and create a shipment order for the above sales order.
    Create a new Shipment order with following details
    Header
        *Business Partner = mcgiver
    Lines
        *Create a line for product A alone.
    Complete the shipment order.

  Hence according to the definition now the sales order should appear in the drop down of sales invoice "Create Line From" pop up page(Sales Management || Transactions || Sales Invoice || Header ) .

2.Create a new sales order (Sales Management || Transactions || Sales Order) with following "After order delivered" Invoice Terms.

  Definition for "After order delivered" Invoice Term :
      In this case the customer wants to be invoiced after all lines on the sales order have been delivered

  Header
      *Invoice Terms=After order delivered.
      *Business Partner = mcgiver
  Line
      *Create two lines for product A & B
        #Product A=5
        #Product B=3
  Complete the sales order.
  Now go to Goods Shipment (Sales Management || Transactions || Goods Shipment || Header) and create a shipment order for the above sales order.

    Create a new Shipment order with following details
    Header
        *Business Partner = mcgiver
    Using "create lines" button,select the sales order(created above) in the drop down.Select both the products A & B.
    Complete the shipment order.

  Hence according to the definition now the sales order should appear in the drop down of sales invoice "Create Line From" pop up page(Sales Management || Transactions || Sales Invoice || Header ) .

3.Create a new sales order (Sales Management || Transactions || Sales Order) with "Customer Schedule After Delivery" Invoice Terms.

  This invoice term behave similar to above "After order delivered" term.Hence follow the same steps.

4.Create a new sales order (Sales Management || Transactions || Sales Order) with "Do not invoice"
    Definition for "Do not invoice" Invoice Term :
      This invoice term is used for very important customers. The implication is that no invoice gets sent out until the customer give you the go ahead.

  Header
      *Invoice Terms=Do not invoice.
    *Business Partner = mcgiver
  Line
      *Create two lines for product A & B
        #Product A=5
        #Product B=3
  Complete the sales order.
 Now go to Goods Shipment (Sales Management || Transactions || Goods Shipment || Header) and create a shipment order for the above sales order.

    Create a new Shipment order with following details
    Header
        *Business Partner = mcgiver
    Using "create lines" button,select the sales order(created above) in the drop down.Select both the products A & B.
    Complete the shipment order.
  The above sales order should not be displayed in the drop down of sales invoice "Create Line From" pop up page(Sales Management || Transactions || Sales Invoice || Header ) even all the orders are delivered.

5.Create a new sales order (Sales Management || Transactions || Sales Order) with "Immediate" Invoice Terms

  Definition for "Immediate" Invoice Term :
      When the invoice term is Immediate, the invoice for the Sales Order gets created instantly, regardless of whether any shipment of ordered products took place or not.


  Header
      *Invoice Terms=Immediate.
  Line
      *Create two lines for product A & B
        #Product A=5
        #Product B=3
  Complete the sales order.
  Hence with out creating the shipment order we can create invoice for this order.Hence this will appear in the drop down of sales invoice "Create Line From" pop up page(Sales Management || Transactions || Sales Invoice || Header ) .



The functional documentation for the invoice term is available in this link.

http://wiki.openbravo.com/wiki/Functional_Documentation/Sales_Management#Invoice_Terms [^]
(0021751)
hgbot   
2009-11-12 06:40   
Repository: erp/devel/pi
Changeset: 7b6d1c51cb38ad723f4e4cd68f8eb2ca58c5e14a
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Thu Nov 12 11:09:44 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7b6d1c51cb38ad723f4e4cd68f8eb2ca58c5e14a [^]

Fixes Issue 11146: Process \"Create Lines From\" invoices doesn't have into account the Invoice terms set.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0021809)
arunkumar   
2009-11-13 11:54   
Tested & Working fine