0011095: Error in handling write-offs when cancelling payments in settlement

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0011095

Openbravo ERP

09. Financial management

public

2009-10-22 17:50

2011-10-28 12:57

Reporter

OlliJT

Assigned To

vmromanos

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

out of date

Platform

OS Version

rPath Linux

Product Version

2.40MP10

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0011095: Error in handling write-offs when cancelling payments in settlement

Description

If the write-off is left empty, processing of the settlement fails. Follow the steps.

Steps To Reproduce

1. Create a new settlement.
2. Open the pop-up window to select payments to cancel.
3. Select a payment and make the write-off field empty.
4. Create a corresponding payment in the created side.
5. Try to process the settlement.

The last step fails because the write-off field of the canceled payment is empty, which is not taken into account by the procedure.

Proposed Solution

Change in one row in the c_settlement_post function.

Original:
SELECT COALESCE(SUM(C_Currency_Round( C_Currency_Convert((Amount - WriteOffAmt), C_Currency_ID, v_Currency, v_Date, NULL, v_AD_Client_ID, v_AD_Org_ID), v_Currency, NULL)), 0),

Fixed:
SELECT COALESCE(SUM(C_Currency_Round( C_Currency_Convert((Amount - COALESCE(WriteOffAmt, 0)), C_Currency_ID, v_Currency, v_Date, NULL, v_AD_Client_ID, v_AD_Org_ID), v_Currency, NULL)), 0),

Additional Information