Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0011076Openbravo ERP07. Sales managementpublic2009-10-21 18:582012-04-02 06:10
RenateNieuwkoop 
naiaramartinez 
normalminoralways
closedfixed 
5
2.50MP5 
 
Core
No
0011076: Sales Dimensional Report: labels of 'Commercial Document' and 'Commercial File' need relabelling
Sales Management || Analysis Tools || Sales Dimensional Report || Sales Dimensional Report

The secondary filter has the fields 'Commercial Document' and 'Commercial File'.
These descriptions are not very clear of what the content is.

According to the test done by DataFashion the value in the fields are:
Commercial Document: the Sales Rep in the company
Commercial File: a BP that is flagged as Sales rep

These labels should be rewritten to something more meaningful and there should be an explanation in the help text for these fields.
Please treat as defect and not as a feature request.

The labels should be:

Sales Representative on Sales Order
Sales Representative on Business Partner

Both lists should contain the list of sales representative. The first field is used to analyze sales orders that were closed by a particular business partner (the sales rep filter is applied to the sales order); the second field is used to analyze sales orders that are related to business partners for which a particular sales rep is responsible for (the sales rep filter is applied to the business partner).

In most cases the results are the same but they could differ if a customer is moved from one sales rep to the next. The new sales reps might want to use the second filter to see the activities of all their customers (regardless of whom closed the deal) while the old sales reps might want to use the first filter to see the orders they closed (regardless of whom manages the customer now).
OB3-Reviewed, VMA-Reviewed
jpg 211009filtersSalesDimensionalReport.jpg (101,576) 2009-10-21 18:58
https://issues.openbravo.com/file_download.php?file_id=1871&type=bug
jpg
Issue History
2009-10-21 18:58RenateNieuwkoopNew Issue
2009-10-21 18:58RenateNieuwkoopAssigned To => rafaroda
2009-10-21 18:58RenateNieuwkoopFile Added: 211009filtersSalesDimensionalReport.jpg
2009-10-22 12:56rafarodaAssigned Torafaroda => pjuvara
2009-10-23 15:25andreaferacoIssue Monitored: andreaferaco
2009-12-21 14:06pjuvaraAssigned Topjuvara => rafaroda
2009-12-21 14:06pjuvaraTypefeature request => defect
2009-12-21 14:06pjuvaraSteps to Reproduce Updated
2010-02-11 11:20rafarodaAssigned Torafaroda => adrianromero
2011-06-03 11:00dalsasuaAssigned Toadrianromero => dalsasua
2011-07-20 18:10dalsasuaAssigned Todalsasua => jonalegriaesarte
2011-11-24 15:59jonalegriaesarteTag Attached: OB3-Reviewed
2012-02-15 19:03iciordiaAssigned Tojonalegriaesarte => vmromanos
2012-02-16 18:12vmromanosTag Attached: VMA-Reviewed
2012-03-05 12:15naiaramartinezAssigned Tovmromanos => naiaramartinez
2012-03-05 12:15naiaramartinezStatusnew => scheduled
2012-03-05 12:15naiaramartinezfix_in_branch => pi
2012-03-05 12:18naiaramartinezNote Added: 0046038
2012-03-13 16:56hgbotCheckin
2012-03-13 16:56hgbotNote Added: 0046354
2012-03-13 16:56hgbotStatusscheduled => resolved
2012-03-13 16:56hgbotResolutionopen => fixed
2012-03-13 16:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/74e4b296a872d1c7ca6b4ac865e841ead89ada39 [^]
2012-03-13 16:56hgbotCheckin
2012-03-13 16:56hgbotNote Added: 0046355
2012-03-13 16:56vmromanosNote Added: 0046356
2012-03-13 16:56vmromanosStatusresolved => closed
2012-04-02 06:10hudsonbotCheckin
2012-04-02 06:10hudsonbotNote Added: 0047121
2012-04-02 06:10hudsonbotCheckin
2012-04-02 06:10hudsonbotNote Added: 0047122

Notes
(0046038)
naiaramartinez   
2012-03-05 12:18   
Now, if you go to 'Sales Dimensional Report' window, you can see that the labels have been changed: 'Sales Representative on Sales Order' instead of 'Commercial Document' and 'Sales Representative on Business Partner' instead of 'Commercial File'.
(0046354)
hgbot   
2012-03-13 16:56   
Repository: erp/devel/pi
Changeset: 74e4b296a872d1c7ca6b4ac865e841ead89ada39
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Mon Mar 05 12:12:32 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/74e4b296a872d1c7ca6b4ac865e841ead89ada39 [^]

fixed bug 11076 Change labels in Sales Dimensional Report
Now you can see 'Sales Representative On Sales Order' instead of 'Commercial Document' and 'Sales Representative on Business Partner' instead of 'Commercial File'

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
---
(0046355)
hgbot   
2012-03-13 16:56   
Repository: erp/devel/pi
Changeset: e9309e706852772f45dca87c84361fa91e04944b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 13 16:53:45 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9309e706852772f45dca87c84361fa91e04944b [^]

Issue 11076: updated copyright year

---
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
---
(0046356)
vmromanos   
2012-03-13 16:56   
code review + testing OK
(0047121)
hudsonbot   
2012-04-02 06:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047122)
hudsonbot   
2012-04-02 06:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test