Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011029Openbravo ERPA. Platformpublic2009-10-19 10:332009-11-20 00:00
Reporteriperdomo 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Version2.50MP5 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011029: Templates shouldn't allow *data package* to avoid database objects
DescriptionBy definition a template is 'a pack with a configuration script', but currently you can add database objects like tables, columns, etc, to a template and this lead the developer to problems.

If you restrict the user to add records in data package tab, you solve future problems, because to add a table and/or column(s) you need a data package.
Steps To Reproduce* Create a module of type _template_
* Add a new table to the application dictionary

Note: This shouldn't be allowed because is a template
Proposed Solution* Check for the type of module. When entering a record in data package tab, if the module is type *template* raise an error explaining the user that this is conceptually wrong.
Additional Information
TagsModularity
Relationships
Attached Filespng java-package1.png (18,992) 2009-11-18 23:21
https://issues.openbravo.com/file_download.php?file_id=1960&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2009-10-19 10:33iperdomoNew Issue
2009-10-19 10:33iperdomoAssigned To => alostale
2009-10-19 10:35iperdomoTag Attached: Modularity
2009-10-19 10:36iperdomoNote Added: 0021153
2009-10-19 10:36iperdomoversion2.40MP5 => 2.50MP5
2009-10-28 09:14psarobeStatusnew => scheduled
2009-10-28 09:14psarobefix_in_branch => pi
2009-11-17 10:40hgbotCheckin
2009-11-17 10:40hgbotNote Added: 0021907
2009-11-17 10:40hgbotStatusscheduled => resolved
2009-11-17 10:40hgbotResolutionopen => fixed
2009-11-17 10:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9e2261a24770d2a14eb7eff7e04617a4112c8528 [^]
2009-11-17 10:41alostaleNote Added: 0021908
2009-11-18 23:20iperdomoStatusresolved => new
2009-11-18 23:20iperdomoResolutionfixed => open
2009-11-18 23:21iperdomoFile Added: java-package1.png
2009-11-18 23:22iperdomoNote Added: 0021994
2009-11-18 23:23iperdomoStatusnew => scheduled
2009-11-19 08:05hgbotCheckin
2009-11-19 08:05hgbotNote Added: 0022005
2009-11-19 08:05hgbotStatusscheduled => resolved
2009-11-19 08:05hgbotResolutionopen => fixed
2009-11-19 08:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9e2261a24770d2a14eb7eff7e04617a4112c8528 [^] => http://code.openbravo.com/erp/devel/pi/rev/2fe0cdebf4276e12afe1a833f709b159a456d0dd [^]
2009-11-19 10:33iperdomoStatusresolved => closed
2009-11-20 00:00anonymoussf_bug_id0 => 2900814

Notes
(0021153)
iperdomo   
2009-10-19 10:36   
You can also add new windows and tabs, so the combo of modules 'in development' should exclude the templates.
(0021907)
hgbot   
2009-11-17 10:40   
Repository: erp/devel/pi
Changeset: 9e2261a24770d2a14eb7eff7e04617a4112c8528
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Nov 17 10:39:32 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9e2261a24770d2a14eb7eff7e04617a4112c8528 [^]

fixed bug 0011029: Templates shouldn't allow *data package*

---
M src-db/database/model/triggers/AD_MODULE_DBPREFIX_TRG.xml
M src-db/database/model/triggers/AD_PACKAGE_JP_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0021908)
alostale   
2009-11-17 10:41   
The fix includes:
-Do not allow to insert java packages in templates.
-Do not allow to insert db prefixes in templates.
-Do not show templates in module combo when assigning AD elements (windows, tabs, references, etc.)
(0021994)
iperdomo   
2009-11-18 23:22   
The message should say: "Data packages are not allowed, instead of Java Packages".
Attached you'll find a screenshot.
(0022005)
hgbot   
2009-11-19 08:05   
Repository: erp/devel/pi
Changeset: 2fe0cdebf4276e12afe1a833f709b159a456d0dd
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Nov 19 08:04:43 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2fe0cdebf4276e12afe1a833f709b159a456d0dd [^]

fixed bug 11029: Message says data package instead of java package

---
M src-db/database/model/triggers/AD_PACKAGE_JP_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---