Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0010898Openbravo ERPZ. Otherspublic2009-10-07 13:592009-10-23 00:01
shuehner 
alostale 
immediatecriticalhave not tried
closedfixed 
5
pi 
 
Core
No
0010898: Api check build 165 fails
This api check build fails:

http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/165/console [^]

org.openbravo.erpCommon.obps:
Missing
method org.openbravo.erpCommon.obps.ActivationKey.getSubscribedModules(boolean): missing in /var/www/localhost/htdocs/japi/165
method org.openbravo.erpCommon.obps.ActivationKey.isModuleSubscribed(java.lang.String, boolean): missing in /var/www/localhost/htdocs/japi/165
No tags attached.
related to defect 0010822 closed alostale Message displayed when module license is over or not yet started is not correct 
Issue History
2009-10-07 13:59shuehnerNew Issue
2009-10-07 13:59shuehnerAssigned To => alostale
2009-10-07 14:01shuehnerNote Added: 0020847
2009-10-07 14:01shuehnerRelationship addedrelated to 0010822
2009-10-07 15:22alostaleNote Added: 0020851
2009-10-07 15:22alostaleAssigned Toalostale => pjuvara
2009-10-09 09:24psarobeStatusnew => scheduled
2009-10-09 09:24psarobefix_in_branch => pi
2009-10-13 07:16pjuvaraNote Added: 0020946
2009-10-13 07:16pjuvaraAssigned Topjuvara => alostale
2009-10-13 09:48hgbotCheckin
2009-10-13 09:48hgbotNote Added: 0020960
2009-10-13 09:48hgbotStatusscheduled => resolved
2009-10-13 09:48hgbotResolutionopen => fixed
2009-10-13 09:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/6fa216c45a88df4db87e789bc3e7283048de126f [^]
2009-10-22 09:06psarobeStatusresolved => closed
2009-10-23 00:01anonymoussf_bug_id0 => 2884256

Notes
(0020847)
shuehner   
2009-10-07 14:01   
Change introduce by thsi changeset:

changeset: 5170:d54363bb8b4a
user: Asier Lostalé <asier.lostale@openbravo.com>
date: Wed Oct 07 09:35:37 2009 +0200
files: src-db/database/sourcedata/AD_TEXTINTERFACES.xml src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java src/org/openbravo/erpCommon/ad_forms/ModuleManagement_ErrorCommercial.html src/org/openbravo/erpCommon/ad_forms/ModuleManagement_ErrorCommercial.xml src/org/openbravo/erpCommon/obps/ActivationKey.java
description:
fixed bug 0010822: Message displayed when module license is over or not yet started is not correct
(0020851)
alostale   
2009-10-07 15:22   
This API breakage solves issue 0010822.

When checking the commercial modules an instance is subscribed to, it just checked whether the module was currently accessible thus the isModuleSubscribed method returned a boolean but it did not distinguish if the module was not available because it was not subscribed or because the license was expired or not active yet. Now this method returns the actual status for the module, therefore it cannot be a boolean value.

Apart of this, this method is very unlikely to be used by any module since it just check if a module is registered for an instance, so I don't think this change add any risk.
(0020946)
pjuvara   
2009-10-13 07:16   
Exception approved. Please document with an alert.
(0020960)
hgbot   
2009-10-13 09:48   
Repository: erp/devel/api-checks
Changeset: 6fa216c45a88df4db87e789bc3e7283048de126f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Oct 13 09:47:54 2009 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/6fa216c45a88df4db87e789bc3e7283048de126f [^]

fixed issue 0010898: Api check build 165 fails

---
M java/reference/250.japi.gz
---