Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010884Openbravo ERPA. Platformpublic2009-10-06 17:092009-10-21 00:00
Reportershuehner 
Assigned Toshuehner 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version2.40 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010884: Audit all queries using LIKE with respect to _ character which is a wildcard and not a normal char
DescriptionIn Sql (both oracle and postgres) the _ in a LIKE expression is a wildcard for a any single character.

Example:
select * from m_product where name like 'Product_%';

does also match on the name 'Product 12345'...

All queries (i.e. triggers,functions) should be audited and fixed as many assume that '_' matches just the normal '_' character.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00107082.50MP7 closed marvintm Trigger dissapear in module with dependency, in Postgre 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-06 17:09shuehnerNew Issue
2009-10-06 17:09shuehnerAssigned To => rafaroda
2009-10-06 17:09shuehnerOBNetwork customer => No
2009-10-06 17:10shuehnerRelationship addedrelated to 0010708
2009-10-06 17:10shuehnerNote Added: 0020792
2009-10-09 13:22psarobeAssigned Torafaroda => shuehner
2009-10-09 13:22psarobePrioritynormal => low
2009-10-09 13:22psarobeSeveritymajor => minor
2009-10-09 13:22psarobeStatusnew => scheduled
2009-10-14 12:28shuehnerNote Added: 0021002
2009-10-14 12:28shuehnerPrioritylow => urgent
2009-10-14 12:28shuehnerSeverityminor => major
2009-10-20 15:15shuehnerNote Added: 0021211
2009-10-20 15:17shuehnerStatusscheduled => closed
2009-10-20 15:17shuehnerNote Added: 0021212
2009-10-20 15:17shuehnerResolutionopen => no change required
2009-10-21 00:00anonymoussf_bug_id0 => 2882769

Notes
(0020792)
shuehner   
2009-10-06 17:10   
Added relation as issue 10708 is one specified instance of this problem.
(0021002)
shuehner   
2009-10-14 12:28   
Changing to major/urgent as this issue already manifested in one obn issue which might lead to data loss. So check for others is more important.
(0021211)
shuehner   
2009-10-20 15:15   
Three groups of issues were found checking this topic, all issues are present from at least 2.3x on until now:

AD_WINDOW_TRG2.xml and AD_TAG_TRG2.xml
When a window or tab is renamed its ad_model_object_mapping entries are renamed as well. They are found using i.e. the broken LIKE '%_Relation.html' which would also match on '%Relation.html'. However these only for system generated/maintained mapping names so in practice this is never a problem.

AD_TAB_IMPORT.xml
When copying ad_column entries into a tab and a column is named UPDATEDBY and the next columnname matches '%_ID' it will be marked as read only. Again this would also match '%ID' but the rule to mark a column a readonly here is arbitrary and undocumented so not worth fixing it.

AD_TABLE_IMPORT.xml
Used by the 'Create column from db process'. This function does make several matches again '%_something' which also match '%something' but again the special rules for changing a columns attributes are arbitrary and completely undocumented.
(0021212)
shuehner   
2009-10-20 15:17   
As stated in last note:

ad_window/ad_tab trigger: will not happen in practice -> no change required

ad_tab_import/ad_table_import only in arbitrary/undocumented special cases -> wontfix