Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010869Openbravo ERPA. Platformpublic2009-10-05 18:552024-07-17 13:03
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target VersionFixed in Version2.40MP10 
Merge Request Statusopen
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010869: WAD generated one unused xsql method for nearly all generated windows
DescriptionThe generated xsql files for generated windows contain (among others) this two methods:

- select
- selectEdit

The select method is not used in nearly all windows. Additionally the code in the not-used parts is not always valid sql code.

The method should not be generatd if it is not used.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0010868 closed shuehner WAD generated one unused xsql method for nearly all generated windows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-05 18:55shuehnerTypedefect => backport
2009-10-05 18:55shuehnerfix_in_branch => 2.40
2009-10-05 18:56shuehnerNote Added: 0020719
2009-10-05 19:01hgbotCheckin
2009-10-05 19:01hgbotNote Added: 0020721
2009-10-05 19:01hgbotStatusscheduled => resolved
2009-10-05 19:01hgbotResolutionopen => fixed
2009-10-05 19:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/3bf9f8b123ee7e55f8c08f4ef6690e65dab96511 [^]
2009-10-05 19:01hgbotCheckin
2009-10-05 19:01hgbotNote Added: 0020722
2009-10-05 19:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.40/rev/3bf9f8b123ee7e55f8c08f4ef6690e65dab96511 [^] => http://code.openbravo.com/erp/stable/2.40/rev/513cf5cc3de7c26c489400297b4400dd9b043bc4 [^]
2009-10-13 08:30arunkumarStatusresolved => closed
2009-10-13 08:30arunkumarNote Added: 0020953
2009-10-13 08:30arunkumarFixed in Version => 2.40MP10
2024-07-16 14:06hgbotMerge Request Status => open
2024-07-16 14:06hgbotNote Added: 0167015
2024-07-17 12:19Aaron_AlvarezNote Deleted: 0167015
2024-07-17 12:23hgbotNote Added: 0167063
2024-07-17 13:03Aaron_AlvarezTriggers an Emergency Pack => No
2024-07-17 15:35shuehnerNote Deleted: 0167063

Notes
(0020719)
shuehner   
2009-10-05 18:56   
Nice side-effect of changing this, is the removal of about 5MB of unused generated code.
(0020721)
hgbot   
2009-10-05 19:01   
Repository: erp/stable/2.40
Changeset: 3bf9f8b123ee7e55f8c08f4ef6690e65dab96511
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 05 19:00:05 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/3bf9f8b123ee7e55f8c08f4ef6690e65dab96511 [^]

Fixed 10869: Only generate select method if it is needed in a window.
- Reorder selectEdit (used always) to be before select (used very seldom)
- Only generate select method if needed

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/datasource.xsqlxml
---
(0020722)
hgbot   
2009-10-05 19:01   
Repository: erp/stable/2.40
Changeset: 513cf5cc3de7c26c489400297b4400dd9b043bc4
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 05 19:00:56 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/513cf5cc3de7c26c489400297b4400dd9b043bc4 [^]

Issue 10869: Remove leftover fixme

---
M src-wad/src/org/openbravo/wad/Wad.java
---
(0020953)
arunkumar   
2009-10-13 08:30   
Tested & Working fine.