Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010868Openbravo ERPA. Platformpublic2009-10-05 18:552009-10-14 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target VersionFixed in Version2.50MP7 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010868: WAD generated one unused xsql method for nearly all generated windows
DescriptionThe generated xsql files for generated windows contain (among others) this two methods:

- select
- selectEdit

The select method is not used in nearly all windows. Additionally the code in the not-used parts is not always valid sql code.

The method should not be generatd if it is not used.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0010869 closed shuehner WAD generated one unused xsql method for nearly all generated windows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-05 18:55shuehnerNew Issue
2009-10-05 18:55shuehnerAssigned To => shuehner
2009-10-05 18:55shuehnerOBNetwork customer => No
2009-10-05 18:55shuehnerStatusnew => scheduled
2009-10-05 18:55shuehnerfix_in_branch => pi
2009-10-05 18:55shuehnerNote Added: 0020718
2009-10-05 19:03hgbotCheckin
2009-10-05 19:03hgbotNote Added: 0020723
2009-10-05 19:03hgbotStatusscheduled => resolved
2009-10-05 19:03hgbotResolutionopen => fixed
2009-10-05 19:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1f0e6a228a2b000fc7a5d99012f76d15c5f27c09 [^]
2009-10-13 10:07arunkumarStatusresolved => closed
2009-10-13 10:07arunkumarNote Added: 0020963
2009-10-13 10:07arunkumarFixed in Version => 2.50MP7
2009-10-14 00:00anonymoussf_bug_id0 => 2878314

Notes
(0020718)
shuehner   
2009-10-05 18:55   
Nice side-effect of changing this, is the removal of about 5MB of unused generated code.
(0020723)
hgbot   
2009-10-05 19:03   
Repository: erp/devel/pi
Changeset: 1f0e6a228a2b000fc7a5d99012f76d15c5f27c09
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 05 19:02:50 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1f0e6a228a2b000fc7a5d99012f76d15c5f27c09 [^]

Fixed 10868: Only generate select method if it is needed in a window.
- Reorder selectEdit (used always) to be before select (used very seldom)
- Only generate select method if needed

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/datasource.xsqlxml
---
(0020963)
arunkumar   
2009-10-13 10:07   
Tested the files in PI Oracle - src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/datasource.xsqlxml. The commits are reflected in the files.The issue is fixed.