Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010864Openbravo ERPA. Platformpublic2009-10-05 15:072009-10-17 00:00
Reporteralostale 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010864: Check for obx consistency when it is exported.
DescriptionCurrently it is possible to export obx files which are not consistent: it is possible to define dependencies or inclusions which are actually not correct. For example a package can be defined to contain module A 1.0.0, whereas the actual obx contains module A 0.0.5.

When exporting modules this should be verified, and in case it is not satisfied do not allow to the the exportation.
Steps To Reproduce-Create a module A in version 0.0.5
-Create a template
-Include within the template module A
-Set the module version in the template's inclusion 1.0.0
-Export obx file
Proposed SolutionThere are 2 kind of check to be performed:

*Dependency:
  -It must be checked the dependencies are actually installed and they are within the range the dependencies define.

*Inclusion:
  -It must be checked the version of the modules that are within the dependencies are exactly the ones that are defined in the inclusion.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00106772.50MP7 closed alostale Dependencies are not working well under some circumstances 
related to feature request 0010430 scheduled Triage Platform Base Export module validation must check the 'has reference data' when a dataset is present in the module 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-05 15:07alostaleNew Issue
2009-10-05 15:07alostaleAssigned To => alostale
2009-10-05 15:08alostaleRelationship addedrelated to 0010677
2009-10-06 09:36alostaleRelationship addedrelated to 0010430
2009-10-09 10:23psarobeStatusnew => scheduled
2009-10-09 10:23psarobefix_in_branch => pi
2009-10-09 16:02hgbotCheckin
2009-10-09 16:02hgbotNote Added: 0020912
2009-10-09 16:02hgbotStatusscheduled => resolved
2009-10-09 16:02hgbotResolutionopen => fixed
2009-10-09 16:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/34c4a57ded905c8f0743f6a94a3335d8b7ab1d38 [^]
2009-10-16 17:34marvintmStatusresolved => closed
2009-10-16 17:34marvintmNote Added: 0021125
2009-10-17 00:00anonymoussf_bug_id0 => 2880779

Notes
(0020912)
hgbot   
2009-10-09 16:02   
Repository: erp/devel/pi
Changeset: 34c4a57ded905c8f0743f6a94a3335d8b7ab1d38
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Oct 09 16:01:29 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/34c4a57ded905c8f0743f6a94a3335d8b7ab1d38 [^]

fixed issue 0010864: Check for obx consistency when it is exported

---
M src/org/openbravo/erpCommon/modules/VersionUtility.java
M src/org/openbravo/service/system/ModuleValidator.java
---
(0021125)
marvintm   
2009-10-16 17:34   
I've created two modules. First I created a normal dependency between them, and set it both to a previous version, and to a newer version of the module in the database. It failed on both cases (which is correct).

Then I created inclusion dependencies (as before, to a previous and newer version). It also failed on both cases (which is also correct).

Therefore the check works correctly.