Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010810Openbravo ERP09. Financial managementpublic2009-09-29 12:172009-11-19 00:00
Reportergorkaion 
Assigned Toeduardo_Argal 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionGentoo
Product Version2.50MP1 
Target Version2.50MP9Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010810: Duplicate lines in remittance file when a partner has deactivated accounts
DescriptionWhen a business partner has one active bank account and several deactivated accounts the BANK.DAT file is generated with duplicate lines.

There is a check that covers the existence of more than one active bank account for a business partner. But the query that retrieves the lines doesn't filter by the active flag.
Steps To ReproduceIn Master Data Management || Business Partner || Business Partner >> Bank Account
Take a business partner and set 2 bank accounts, one active and one not active.

Create a remittance containing a payment of that Business Partner (the payment can be generated through an invoice).

Create the file. Notice that the payment appears twice once per each bank account.

Go back to the partner and activate both accounts.
Try to create the file again, a message indicating that the partner has 2 accounts appear.
Proposed SolutionModify the selectLineas method of CreateFile34_data.xsql file so the c_bp_bankaccount table is filtered by isActive='Y'
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-09-29 12:17gorkaionNew Issue
2009-09-29 12:17gorkaionAssigned To => rafaroda
2009-09-29 13:56rafarodaNote Added: 0020453
2009-09-29 13:56rafarodaStatusnew => feedback
2009-09-29 14:05gorkaionStatusfeedback => new
2009-09-29 14:05gorkaionversion => 2.50MP1
2009-09-29 14:06rafarodaAssigned Torafaroda => dalsasua
2009-09-29 14:06rafarodaPriorityimmediate => urgent
2009-09-29 14:06rafarodaStatusnew => scheduled
2009-10-27 12:21networkbTarget Version2.50MP8 => 2.50MP9
2009-11-06 10:13dmitry_mezentsevNote Added: 0021624
2009-11-06 10:14dmitry_mezentsevAssigned Todalsasua => eduardo_Argal
2009-11-10 10:57hgbotCheckin
2009-11-10 10:57hgbotNote Added: 0021675
2009-11-10 10:57hgbotStatusscheduled => resolved
2009-11-10 10:57hgbotResolutionopen => fixed
2009-11-10 10:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6cdff471ba6421f093deb74c933186238d325c59 [^]
2009-11-10 11:43hgbotCheckin
2009-11-10 11:43hgbotNote Added: 0021678
2009-11-10 11:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6cdff471ba6421f093deb74c933186238d325c59 [^] => http://code.openbravo.com/erp/devel/pi/rev/50d12d21ba0978f11600783a11b9cdfb04dea5ec [^]
2009-11-11 10:45sureshbabuStatusresolved => new
2009-11-11 10:45sureshbabuResolutionfixed => open
2009-11-11 10:45sureshbabuNote Added: 0021712
2009-11-16 11:27rafarodaStatusnew => scheduled
2009-11-16 11:27rafarodaFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/50d12d21ba0978f11600783a11b9cdfb04dea5ec [^] =>
2009-11-16 15:35dmitry_mezentsevNote Added: 0021861
2009-11-18 09:56eduardo_ArgalStatusscheduled => resolved
2009-11-18 09:56eduardo_ArgalFixed in SCM revision => 50d12d21ba09
2009-11-18 09:56eduardo_ArgalResolutionopen => fixed
2009-11-18 09:57eduardo_ArgalStatusresolved => closed
2009-11-19 00:00anonymoussf_bug_id0 => 2900147

Notes
(0020453)
rafaroda   
2009-09-29 13:56   
Please specify a product verion.

Thanks.
(0021624)
dmitry_mezentsev   
2009-11-06 10:13   
Eduardo,

This is the issue we discussed (expiring in 5 days).
(0021675)
hgbot   
2009-11-10 10:57   
Repository: erp/devel/pi
Changeset: 6cdff471ba6421f093deb74c933186238d325c59
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri Nov 06 13:05:22 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6cdff471ba6421f093deb74c933186238d325c59 [^]

Fixes bug 0010810: Duplicate lines in remittance...

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFile34_data.xsql
M src/org/openbravo/erpCommon/ad_actionButton/CreateFile_data.xsql
---
(0021678)
hgbot   
2009-11-10 11:43   
Repository: erp/devel/pi
Changeset: 50d12d21ba0978f11600783a11b9cdfb04dea5ec
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Tue Nov 10 11:41:25 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/50d12d21ba0978f11600783a11b9cdfb04dea5ec [^]

Fixes bug 0010810: Duplicate lines in remittance...

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFile34_data.xsql
---
(0021712)
sureshbabu   
2009-11-11 10:45   
Hi Edu,

I retested the issue as per the description,

As per the proposed solution, the Active flag filter is rightly applied while generating the file, but when i tried to create a file with two or more active bank accounts for a business partner, the error message appears in the dialog box and then the dialog box with error message disappears(closed) automatically with out any button click.
(0021861)
dmitry_mezentsev   
2009-11-16 15:35   
Hi Eduardo,

Could you please clean this one to finally close it?

Thanks.