Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010797Openbravo ERP00. Application dictionarypublic2009-09-28 21:252012-04-28 02:31
Reportericiordia 
Assigned Tonaiaramartinez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionrPath Linux
Product Versionpi 
Target VersionFixed in Version3.0MP12 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010797: Product window is not checked as "Sales transaction" in AD
DescriptionProduct window is not checked as "Sales transaction" in AD. As a result, fields in that window are not synchronized from element.name but from element.PO name

A window should be defined as "Sales transaction" by default. Only in case that window uses tables that are shared between sales and purchase transactions (c_order, m_inout, c_invoice) then it should be declared as not "Sales transaction", this way those fields will get its name, help and description from po name, po help and po description in ad_element.

Review all windows declared as not "Sales transaction" (eg. Price List has the same problem) and change to 'Y' when appropiate.

Additionally, "Sales transaction" is a poor/misleading label. Rename it as "Common/sales transaction" (it would be better to change the semantic of that column so it is called "Purchase transaction", but it can not be done within 2.50 release because of API stability).
Steps To Reproduce
Proposed SolutionAD_Window.isSoTRX is also used by business partner selector so by default it filters by vendors. It should be refactored in 3.0. In 2.50 the proposed solution is to use PO name, PO description and PO help instead
Additional Information
TagsOB3-Reviewed, VMA-Reviewed
Relationships
related to defect 00206423.0MP12 closed naiaramartinez Business partner selector in Purchasing tab of Product window shows Customers by default 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-09-28 21:25iciordiaNew Issue
2009-09-28 21:25iciordiaAssigned To => rafaroda
2009-09-28 21:25iciordiaOBNetwork customer => No
2009-09-29 22:41psarobeStatusnew => scheduled
2009-09-29 22:41psarobefix_in_branch => pi
2010-02-11 18:05rafarodaAssigned Torafaroda => adrianromero
2011-06-03 11:00dalsasuaAssigned Toadrianromero => dalsasua
2011-07-20 18:11dalsasuaAssigned Todalsasua => jonalegriaesarte
2011-11-24 15:52jonalegriaesarteTag Attached: OB3-Reviewed
2012-02-15 19:03iciordiaAssigned Tojonalegriaesarte => vmromanos
2012-02-16 18:14vmromanosTag Attached: VMA-Reviewed
2012-04-24 09:48naiaramartinezAssigned Tovmromanos => naiaramartinez
2012-04-24 13:10naiaramartinezNote Added: 0047908
2012-04-26 12:45hgbotCheckin
2012-04-26 12:45hgbotNote Added: 0048016
2012-04-26 12:45hgbotStatusscheduled => resolved
2012-04-26 12:45hgbotResolutionopen => fixed
2012-04-26 12:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/abbf0e7f2325440d3e3d391f3ca1e82ef3a0fe2c [^]
2012-04-26 12:53miruritaNote Added: 0048023
2012-04-26 12:53miruritaStatusresolved => closed
2012-04-26 12:53miruritaFixed in Version => 3.0MP12
2012-04-28 02:31hudsonbotCheckin
2012-04-28 02:31hudsonbotNote Added: 0048157
2012-05-30 14:07ngarciaRelationship addedrelated to 0020642

Notes
(0047908)
naiaramartinez   
2012-04-24 13:10   
Test Plan:
  Go to the database and execute the following SQL query:
    SELECT * FROM AD_WINDOW WHERE ISSOTRX='N'

  Notice that result is showing windows that they need to be issotrx='n'.
(0048016)
hgbot   
2012-04-26 12:45   
Repository: erp/devel/pi
Changeset: abbf0e7f2325440d3e3d391f3ca1e82ef3a0fe2c
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Thu Apr 26 11:24:42 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/abbf0e7f2325440d3e3d391f3ca1e82ef3a0fe2c [^]

fixed bug 10797 Set sales transaction ='Y' in windows when appropiate

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_WINDOW.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_WINDOW.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_WINDOW.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_WINDOW.xml
---
(0048023)
mirurita   
2012-04-26 12:53   
code review + testing OK

The following windows has been set as Sales Transaction = 'Y'
- Organization Type
- Product
- Price List
- Bank
- Datasource
- Data File Type
- Work Center
- Template
- Open/Close Period Control
- Window Personalization

Elements are synchronized using 'Sales' element information.
(0048157)
hudsonbot   
2012-04-28 02:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^]

Maturity status: Test