Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010715Openbravo ERPA. Platformpublic2009-09-23 15:392009-10-17 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010715: On SQL error when using ComboTableData on postgres only error message is '0' instead of the real database error
DescriptionThe error reporting code inside ComboTableData does throw away the error message text and only keep the error code number. This lead to completely useless errror message shown to the user.
Steps To Reproduce1.) Produce an sql error in some sql executes by ComboTableData
update ad_ref_table set whereclause = 'XISTS (SELECT * FROM C_BPartner bp WHERE AD_User.C_BPartner_ID=bp.C_BPartner_ID AND bp.IsSalesRep=\'Y\')' where ad_reference_id = 190;
2.) Login as openbravo admin
3.) Go to masterdata management -> Product
4.) Error message 'Error: 0' (on postgres) is shown
Proposed SolutionFix ComboTableData to not throw away the database provided error message. This is not perfect but provides (depending on the real sql error) more info to report in a support ticket.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0010344 closed shuehner org.openbravo.erpCommon.utility.ComboTableData performance issue on PostgreSQL 
depends on backport 0010716 closed shuehner On SQL error when using ComboTableData on postgres only error message is '0' instead of the real database error 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-09-23 15:39shuehnerNew Issue
2009-09-23 15:39shuehnerAssigned To => shuehner
2009-09-23 15:39shuehnerNote Added: 0020315
2009-09-23 15:39shuehnerRelationship addedrelated to 0010318
2009-09-23 15:40shuehnerStatusnew => scheduled
2009-09-23 15:40shuehnerfix_in_branch => pi
2009-09-23 15:40shuehnerRelationship addedrelated to 0010344
2009-09-23 15:40shuehnerRelationship deletedrelated to 0010318
2009-09-23 15:51hgbotCheckin
2009-09-23 15:51hgbotNote Added: 0020316
2009-09-23 15:51hgbotStatusscheduled => resolved
2009-09-23 15:51hgbotResolutionopen => fixed
2009-09-23 15:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7c302cdb1c7fb0dffc75218fdc78c4981f71b14e [^]
2009-09-23 16:12psarobeTag Attached: 250mp6
2009-09-24 19:12psarobeTag Detached: 250mp6
2009-09-29 14:17hgbotCheckin
2009-09-29 14:17hgbotNote Added: 0020507
2009-09-29 14:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7c302cdb1c7fb0dffc75218fdc78c4981f71b14e [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/7c302cdb1c7fb0dffc75218fdc78c4981f71b14e [^]
2009-10-16 12:43marvintmStatusresolved => closed
2009-10-16 12:43marvintmNote Added: 0021105
2009-10-17 00:00anonymoussf_bug_id0 => 2880776

Notes
(0020315)
shuehner   
2009-09-23 15:39   
Note the steps to reproduce contain an artificial testcase just to reproduce an error here. The real error came up when testing the patch attached to issue 10318.
(0020316)
hgbot   
2009-09-23 15:51   
Repository: erp/devel/pi
Changeset: 7c302cdb1c7fb0dffc75218fdc78c4981f71b14e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Sep 23 15:50:13 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7c302cdb1c7fb0dffc75218fdc78c4981f71b14e [^]

Fixed 10715: Fix error reporting in ComboTableData, don't throw away error text

---
M src/org/openbravo/erpCommon/utility/ComboTableData.java
---
(0020507)
hgbot   
2009-09-29 14:17   
Repository: erp/devel/pi-pageddatagrid
Changeset: 7c302cdb1c7fb0dffc75218fdc78c4981f71b14e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Sep 23 15:50:13 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/7c302cdb1c7fb0dffc75218fdc78c4981f71b14e [^]

Fixed 10715: Fix error reporting in ComboTableData, don't throw away error text

---
M src/org/openbravo/erpCommon/utility/ComboTableData.java
---
(0021105)
marvintm   
2009-10-16 12:43   
I followed the steps to reproduce the problem, and I got the new, improved message.