Openbravo Issue Tracking System - Openbravo ERP  | 
| View Issue Details | 
  | 
| ID | Project | Category | View Status | Date Submitted | Last Update | 
| 0010588 | Openbravo ERP | 03. Procurement management | public | 2009-09-14 19:25 | 2009-10-06 11:27 | 
  | 
| Reporter | shuehner |   | 
| Assigned To | shuehner |   | 
| Priority | high | Severity | major | Reproducibility | N/A | 
| Status | closed | Resolution | fixed |   | 
| Platform |  | OS | 5 | OS Version |  | 
| Product Version | 2.40 |   | 
| Target Version |  | Fixed in Version | 2.50MP6 |   | 
| Merge Request Status |  | 
| Review Assigned To |  | 
| OBNetwork customer | No | 
| Web browser |  | 
| Modules | Core | 
| Support ticket |  | 
| Regression level |  | 
| Regression date |  | 
| Regression introduced in release |  | 
| Regression introduced by commit |  | 
| Triggers an Emergency Pack | No | 
  | 
| Summary | 0010588: CreateFromMultiple_Receipt_data.xsql has optional filter on M_LOCATOR.M_LOCATOR_TYPE_ID which was removed in 2.3x -> 2.40 | 
| Description | This xsql-file: 
 
src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql 
 
has the following optional parameter: 
 
<Parameter name="mLocatortypeId" optional="true" after="AND 1=1" text=" AND L.M_LOCATOR_TYPE_ID = ? "/> 
 
referencing a now non-existant column m_locator_type_id in the m_locator table. This column was removed somewhere between 2.3x -> 2.40 
 
Planned changes to speed up the build would execute the slqc-queries and also include this optional parameter in the query which will obviously fail. 
 
The query (and parameter) is used from the CreateFromMultiple servlet. | 
| Steps To Reproduce |  | 
| Proposed Solution | Remove the optional parameter from the xsql file (as the column does not exist) and check/remove/change the locator_type logic in the servlet. | 
| Additional Information |  | 
| Tags | No tags attached. | 
| Relationships | | depends on  | backport  | 0010617 |   | closed  | shuehner  | CreateFromMultiple_Receipt_data.xsql has optional filter on M_LOCATOR.M_LOCATOR_TYPE_ID which was removed in 2.3x -> 2.40  |  | blocks  | defect  | 0004038 |   | closed  | shuehner  | Slow compilation in sqlC part due to high amount of data  |  
  | 
| Attached Files |  | 
  | 
| Issue History | 
| Date Modified | Username | Field | Change | 
| 2009-09-14 19:25 | shuehner | New Issue |  | 
| 2009-09-14 19:25 | shuehner | Assigned To |  => rafaroda | 
| 2009-09-14 19:25 | shuehner | OBNetwork customer |  => No | 
| 2009-09-14 19:26 | shuehner | Note Added: 0019931 |  | 
| 2009-09-14 19:26 | shuehner | Relationship added | blocks 0004038 | 
| 2009-09-15 20:57 | shuehner | Assigned To | rafaroda => shuehner | 
| 2009-09-15 20:57 | shuehner | Status | new => scheduled | 
| 2009-09-15 20:57 | shuehner | fix_in_branch |  => pi | 
| 2009-09-15 21:03 | hgbot | Checkin |  | 
| 2009-09-15 21:03 | hgbot | Note Added: 0020100 |  | 
| 2009-09-15 21:03 | hgbot | Status | scheduled => resolved | 
| 2009-09-15 21:03 | hgbot | Resolution | open => fixed | 
| 2009-09-15 21:03 | hgbot | Fixed in SCM revision |  => http://code.openbravo.com/erp/devel/pi/rev/29c8320f0292a89cd372952a8d664605b5b88e94 [^] | 
| 2009-09-18 13:30 | psarobe | Status | resolved => closed | 
| 2009-09-18 13:30 | psarobe | Fixed in Version |  => 2.50MP6 | 
| 2009-09-19 00:00 | anonymous | sf_bug_id | 0 => 2861737 | 
| 2009-09-29 14:12 | hgbot | Checkin |  | 
| 2009-09-29 14:12 | hgbot | Note Added: 0020470 |  | 
| 2009-09-29 14:12 | hgbot | Status | closed => resolved | 
| 2009-09-29 14:12 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/29c8320f0292a89cd372952a8d664605b5b88e94 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/29c8320f0292a89cd372952a8d664605b5b88e94 [^] | 
| 2009-10-06 11:27 | psarobe | Status | resolved => closed | 
| 2009-10-06 11:27 | psarobe | Note Added: 0020757 |  | 
	| 
		Notes	 | 
	
		 
	 | 
	| 
		
	 | 
	
		
		
			| 
				Fix is needed in 2.40 and 2.50 as it blocks the speedup sqlc issue.			 | 
		 
		 
	 | 
	
		 
	 | 
	
		
		
			| 
				(0020100)
			 | 
		 
		
			| 
				hgbot   
			 | 
		 
		
			| 
				2009-09-15 21:03   
							 | 
		 
		 
	 | 
	
		
		
			
				Repository: erp/devel/pi 
Changeset: 29c8320f0292a89cd372952a8d664605b5b88e94 
Author: Stefan Hühner <stefan.huehner <at> openbravo.com> 
Date: Tue Sep 15 21:03:23 2009 +0200 
URL: http://code.openbravo.com/erp/devel/pi/rev/29c8320f0292a89cd372952a8d664605b5b88e94 [^] 
 
Fixed 10588: Fix sql error by removing filter on now non-existant column 
- The file did filter on m_locator.m_locator_type_id which was removed before 2.40 
- Removes code the combobox for 'Locator Type' from the html,xml,java 
- Remove use and pass down to parameter of the m_locator_type_id value 
 
--- 
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.html 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.xml 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql 
--- 
			 | 
		 
		 
	 | 
	
		 
	 | 
	
		
		
			| 
				(0020470)
			 | 
		 
		
			| 
				hgbot   
			 | 
		 
		
			| 
				2009-09-29 14:12   
							 | 
		 
		 
	 | 
	
		
		
			
				Repository: erp/devel/pi-pageddatagrid 
Changeset: 29c8320f0292a89cd372952a8d664605b5b88e94 
Author: Stefan Hühner <stefan.huehner <at> openbravo.com> 
Date: Tue Sep 15 21:03:23 2009 +0200 
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/29c8320f0292a89cd372952a8d664605b5b88e94 [^] 
 
Fixed 10588: Fix sql error by removing filter on now non-existant column 
- The file did filter on m_locator.m_locator_type_id which was removed before 2.40 
- Removes code the combobox for 'Locator Type' from the html,xml,java 
- Remove use and pass down to parameter of the m_locator_type_id value 
 
--- 
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.html 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.xml 
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql 
--- 
			 | 
		 
		 
	 | 
	
		 
	 | 
	| 
		
	 | 
	
		
		
			| 
				Closed again because hudson has reopened without no reason			 | 
		 
		 
	 |