Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0010571Openbravo ERP09. Financial managementpublic2009-09-11 17:222009-10-06 11:27
networkb 
vmromanos 
immediatemajoralways
closedfixed 
20rPath Linux
2.50MP5 
2.50MP62.50MP6 
Core
No
0010571: debt payment generated in "create from" in bank statement are not correct. See the added note
in create from of bank statement, when you select a debt payment receipt, and partial amount, the debts payments generated are not correct
. Create purchase invoice, document type "AP Invoice", with grand total amount 100 euros. Process it. A debt payment is generated with amount 100 euros and field "receipts" is not checked.

. Create a new bank statement.
. execute "create lines from":
   . search the debt payment generated in purchase invoice
   . the proposed amount is -100.
    change the proposed amount from -100 to -75. press ok.

. a settlement is generated with the origin debt payment in the tab "cancelled", and two debt payments in tab "created":
   a debt payment with amount -75 and check payment not selected.
   other debt payment with amount 175 and check payment not selected.
   
The debt payments generated should be of 75 and 25 euros
No tags attached.
related to defect 00107452.50MP7 closed vmromanos "create lines from" in bank statemnet generates incorrect settlement 
Issue History
2009-09-11 17:22networkbNew Issue
2009-09-11 17:22networkbAssigned To => rafaroda
2009-09-11 17:56psarobeStatusnew => scheduled
2009-09-11 17:56psarobeNote Added: 0019815
2009-09-11 17:56psarobeAssigned Torafaroda => dalsasua
2009-09-11 17:56psarobefix_in_branch => pi
2009-09-11 17:57psarobeAssigned Todalsasua => vmromanos
2009-09-11 17:57psarobefix_in_branchpi =>
2009-09-11 17:57psarobeSummarydebt payment generated in "create from" in bank statement are not correct => debt payment generated in "create from" in bank statement are not correct. See the added note
2009-09-11 18:00rafarodaPriorityimmediate => urgent
2009-09-15 16:19rafarodaPriorityurgent => immediate
2009-09-15 16:22rafarodaNote Added: 0020074
2009-09-16 11:13hgbotCheckin
2009-09-16 11:13hgbotNote Added: 0020106
2009-09-16 11:13hgbotStatusscheduled => resolved
2009-09-16 11:13hgbotResolutionopen => fixed
2009-09-16 11:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f691da514c18f003d9e44699bba7adbcdefa83a7 [^]
2009-09-17 13:48psarobeNote Edited: 0019815
2009-09-17 15:46sureshbabuStatusresolved => closed
2009-09-17 15:46sureshbabuNote Added: 0020147
2009-09-17 15:46sureshbabuFixed in Version => 2.50MP6
2009-09-18 00:00anonymoussf_bug_id0 => 2861011
2009-09-22 19:41networkbStatusclosed => new
2009-09-22 19:41networkbResolutionfixed => open
2009-09-22 19:41networkbNote Added: 0020287
2009-09-22 19:41networkbFixed in Version2.50MP6 =>
2009-09-22 19:42networkbAssigned Tovmromanos => rafaroda
2009-09-23 06:30rafarodaNote Added: 0020290
2009-09-23 06:30rafarodaAssigned Torafaroda => vmromanos
2009-09-23 06:30rafarodaStatusnew => scheduled
2009-09-23 10:28vmromanosNote Added: 0020301
2009-09-23 10:32rafarodaNote Added: 0020303
2009-09-23 10:32rafarodaStatusscheduled => feedback
2009-09-23 15:00networkbNote Added: 0020312
2009-09-23 15:12rafarodaStatusfeedback => scheduled
2009-09-23 15:12rafarodaNote Added: 0020313
2009-09-23 15:12rafarodaStatusscheduled => resolved
2009-09-23 15:13rafarodaStatusresolved => closed
2009-09-23 15:13rafarodaNote Added: 0020314
2009-09-23 15:13rafarodaFixed in Version => 2.50MP6
2009-09-25 07:07rafarodaRelationship addedrelated to 0010745
2009-09-29 14:12hgbotCheckin
2009-09-29 14:12hgbotNote Added: 0020472
2009-09-29 14:12hgbotStatusclosed => resolved
2009-09-29 14:12hgbotResolutionopen => fixed
2009-09-29 14:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f691da514c18f003d9e44699bba7adbcdefa83a7 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/f691da514c18f003d9e44699bba7adbcdefa83a7 [^]
2009-10-06 11:27psarobeStatusresolved => closed
2009-10-06 11:27psarobeNote Added: 0020758

Notes
(0019815)
psarobe   
2009-09-11 17:56   
(edited on: 2009-09-17 13:48)
Hi,

The payments are created perfect. That's not the problem. The issue comes because the proposed amount (in the "create lines from pop-up") is in negative when it is not a receipt (purchase invoice) and this is not correct. The proposed amount must be in positive because what it determines whether an payment is a collection or a receipt is the check "Is receipt".

If the payment is in positive it will work.

(0020074)
rafaroda   
2009-09-15 16:22   
Priority upgraded to Immediate since 2.50 MP6 freezing is happening on Friday 18/09.
(0020106)
hgbot   
2009-09-16 11:13   
Repository: erp/devel/pi
Changeset: f691da514c18f003d9e44699bba7adbcdefa83a7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Sep 16 11:10:19 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f691da514c18f003d9e44699bba7adbcdefa83a7 [^]

Fixed bug 10571: debt payment generated in create from in bank statement are not correct

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Bank_data.xsql
---
(0020147)
sureshbabu   
2009-09-17 15:46   
Tested working fine
(0020287)
networkb   
2009-09-22 19:41   
in "create from" of bank statement, when amount selected is the same than amount debt payment, a new settlement is generated with two debt payments:
first debt payment with total amount, and second with 0.
(0020290)
rafaroda   
2009-09-23 06:30   
Víctor,

Can you please review the fix?

Thanks.
(0020301)
vmromanos   
2009-09-23 10:28   
Hi,

You're right, this is another bug.

The fix we did was just to show the proper amount (positive amount) in the create from window. However there is another bug in the create from process that creates two debt payments, one of them with 0 amount which is totally wrong.

So, this issue is properly fixed but we have to open a new one with the new discovered bug.

Regards
(0020303)
rafaroda   
2009-09-23 10:32   
Can you please comment on the note added by Víctor?

Thanks.
(0020312)
networkb   
2009-09-23 15:00   
Ok, i agree
(0020313)
rafaroda   
2009-09-23 15:12   
Issue properly resolved.

Open a new issue for "the create from process that creates two debt payments, one of them with 0 amount which is totally wrong."
(0020314)
rafaroda   
2009-09-23 15:13   
Previously tested and approved by QA.
(0020472)
hgbot   
2009-09-29 14:12   
Repository: erp/devel/pi-pageddatagrid
Changeset: f691da514c18f003d9e44699bba7adbcdefa83a7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Sep 16 11:10:19 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/f691da514c18f003d9e44699bba7adbcdefa83a7 [^]

Fixed bug 10571: debt payment generated in create from in bank statement are not correct

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Bank_data.xsql
---
(0020758)
psarobe   
2009-10-06 11:27   
Closed again because hudson has reopened without no reason