Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010336Openbravo ERP04. Warehouse managementpublic2009-08-19 13:402009-12-11 18:01
Reporternetworkb 
Assigned Torafaroda 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionrPath Linux
Product Version2.50MP2 
Target Version2.50MP6Fixed in Version2.50MP6 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010336: Forced atribute set instance in some post processes when it is not needed
DescriptionIn some post PLs, an attribute set instance is required in lines being processed when the product selected has an attribute set. That is usually fine but not when the product has already its own attribute set instance associated.

PLs:
M_INOUT_POST
M_INTERNAL_CONSUMPTION_POST
M_INVENTORY_POST
M_MOVEMENT_POST
Steps To ReproduceMaster Data Management || Product Setup || Attribute Set || Attribute Set
  new attribute set "Lote" with, for example, lot checked

Master Data Management || Product || Product ->
 create new product with attribute set "Lote" and "attribute set value" filled


Procurement Management || Transactions || Purchase order || Header
  Create new order "O1"


Procurement Management || Transactions || Purchase order || Line
  Create new with this product. Attribute set is void
process this order.


Procurement Management || Transactions || Goods Receipt || Header
  Create new
  Create lines with "Create lines" process.
  Select lines from order "O1", with attribute set void

Process this shipment -> error is returned
Proposed SolutionThe way to resolve the bug is to verify that the product has its attributte set
instance null before asking for having filling that field in the document being process.

The process to modify are:
M_INOUT_POST
M_INTERNAL_CONSUMPTION_POST
M_INVENTORY_POST
M_MOVEMENT_POST

the code to insert
AND P.m_attributesetinstance_id IS NULL

the lines between the code inserted

AND P.M_ATTRIBUTESET_ID IS NOT NULL
( AND P.m_attributesetinstance_id IS NULL)
AND COALESCE(M.M_ATTRIBUTESETINSTANCE_ID, '0') = '0'
Additional Information
TagsNo tags attached.
Relationships
related to defect 00115132.50MP11 closed rafaroda Error in m_storage_detail 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-08-19 13:40networkbNew Issue
2009-08-19 13:40networkbAssigned To => rafaroda
2009-08-19 13:41rafarodaNote Added: 0019054
2009-08-19 13:41rafarodaStatusnew => feedback
2009-08-19 15:00networkbProposed Solution updated
2009-08-19 15:00networkbSteps to Reproduce Updated
2009-08-20 08:31networkbTarget Version => 2.50MP5
2009-08-20 08:31networkbProposed Solution updated
2009-08-20 09:21networkbProposed Solution updated
2009-08-20 09:37rafarodaAssigned Torafaroda => balamurugan
2009-08-20 09:37rafarodaPriorityimmediate => urgent
2009-08-20 09:37rafarodaStatusfeedback => scheduled
2009-08-26 13:14networkbProposed Solution updated
2009-09-03 16:52networkbTarget Version2.50MP5 => 2.50MP6
2009-09-14 07:24rafarodaAssigned Tobalamurugan => rafaroda
2009-09-14 08:53rafarodaNote Added: 0019876
2009-09-15 09:33hgbotCheckin
2009-09-15 09:33hgbotNote Added: 0020019
2009-09-15 09:33hgbotStatusscheduled => resolved
2009-09-15 09:33hgbotResolutionopen => fixed
2009-09-15 09:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7185146af9f0f2c8e496221f399d0815d1783549 [^]
2009-09-15 09:45hudsonbotCheckin
2009-09-15 09:45hudsonbotNote Added: 0020022
2009-09-15 09:50hudsonbotCheckin
2009-09-15 09:50hudsonbotNote Added: 0020029
2009-09-15 10:57hudsonbotCheckin
2009-09-15 10:57hudsonbotNote Added: 0020041
2009-09-15 11:09hudsonbotCheckin
2009-09-15 11:09hudsonbotNote Added: 0020047
2009-09-15 12:12hudsonbotCheckin
2009-09-15 12:12hudsonbotNote Added: 0020054
2009-09-15 12:27hudsonbotCheckin
2009-09-15 12:27hudsonbotNote Added: 0020055
2009-09-15 12:36hudsonbotCheckin
2009-09-15 12:36hudsonbotNote Added: 0020069
2009-09-15 12:52hudsonbotCheckin
2009-09-15 12:52hudsonbotNote Added: 0020070
2009-09-16 14:04sureshbabuStatusresolved => closed
2009-09-16 14:04sureshbabuNote Added: 0020110
2009-09-16 14:04sureshbabuFixed in Version => pi
2009-09-16 14:04sureshbabuNote Edited: 0020110
2009-09-17 00:00anonymoussf_bug_id0 => 2860317
2009-09-29 14:11hgbotCheckin
2009-09-29 14:11hgbotNote Added: 0020463
2009-09-29 14:11hgbotStatusclosed => resolved
2009-09-29 14:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7185146af9f0f2c8e496221f399d0815d1783549 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/7185146af9f0f2c8e496221f399d0815d1783549 [^]
2009-10-06 11:22psarobeStatusresolved => closed
2009-10-06 11:22psarobeNote Added: 0020752
2009-10-06 11:22psarobeFixed in Versionpi => 2.50MP6
2009-12-11 18:01psarobeRelationship addedrelated to 0011513

Notes
(0019054)
rafaroda   
2009-08-19 13:41   
Please provide clear and detailed steps to reproduce this issue.

Thanks.
(0019876)
rafaroda   
2009-09-14 08:53   
Steps to test this fix are the following. Processes should fail for product Cap but not for product Pink Shirt.
1) Create a new product:
* Name = Pink Shirt
* Attribute Set = Color
* Attribute Set Value = Pink
The product gets completely defined by these attributes so there is no need to insert the attribute set value in each of the transactions.
2) In Price tab, assign it a sales and a purchase price list.
3) Create a new product:
* Name = Cap
* Attribute Set = Color
No Attribute Set Value assigned so it will be required for each of the transactions.
4) In Price tab, assign it a sales and a purchase price list.
3) Create physical inventory (Warehouse Management || Transactions || Physical Inventory)
4) Create a line for product Pink Shirt with Quantity Count = 100 (leave Attribute Set Value blank)
5) Create a line for product Cap with Quantity Count = 200 (leave Attribute Set Value blank)
6) Go back to Header and click on Process Inventory Count (M_INVENTORY_POST): process is failing for product Cap.
7) Go back to lines, assign Cap an Attribute Set Value and click on Process Inventory Count again: process completes successfully.
8) Make some good movements (Warehouse Management || Transactions || Goods Movements)
9) Create a line for product Pink Shirt with Movement Quantity = 20 from ML1 to ML4 (leave Attribute Set Value blank)
10) Create a line for product Cap with Movement Quantity = 50 from ML1 to ML2 (leave Attribute Set Value blank)
11) Go back to Header and click on Process Movements (M_MOVEMENT_POST): process is failing for product Cap.
12) Go back to lines, assign Cap an Attribute Set Value and click on Process Movements again: process completes successfully.
13) Create some internal consumption (Production Management || Transactions || Internal Consumption)
14) Create a line for product Pink Shirt with Movement Quantity = 3 (leave Attribute Set Value blank)
15) Create a line for product Cap with Movement Quantity = 5 (leave Attribute Set Value blank)
16) Go back to Header and click on Process Internal Consumption (M_INTERNAL_CONSUMPTION_POST): process is failing for product Cap.
17) Go back to lines, assign Cap an Attribute Set Value and click on Process Internal Consumption again: process completes successfully.
18) Create a goods receipt (Procurement Management || Transactions || Goods Receipt)
19) Create a line for product Pink Shirt with Movement Quantity = 13 (leave Attribute Set Value blank)
20) Create a line for product Cap with Movement Quantity = 15 (leave Attribute Set Value blank)
21) Go back to Header and click on Complete (M_INOUT_POST): process is failing for product Cap.
22) Go back to lines, assign Cap an Attribute Set Value and click on Complete again: process completes successfully.
23) Create a goods shipment (Sales Management || Transactions || Goods Shipment)
24) Create a line for product Pink Shirt with Movement Quantity = 13 (leave Attribute Set Value blank)
25) Create a line for product Cap with Movement Quantity = 15 (leave Attribute Set Value blank)
26) Go back to Header and click on Complete (M_INOUT_POST): process is failing for product Cap.
27) Go back to lines, assign Cap an Attribute Set Value and click on Complete again: process completes successfully.
(0020019)
hgbot   
2009-09-15 09:33   
Repository: erp/devel/pi
Changeset: 7185146af9f0f2c8e496221f399d0815d1783549
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Sun Sep 13 02:19:16 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7185146af9f0f2c8e496221f399d0815d1783549 [^]

Fixes issue 10336 Now products which have both attribute set and attribute set value defined in the product window (they are completely define there), do not require to set the attribute set value in each transaction.

---
M src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
M src-db/database/model/functions/M_INOUT_POST.xml
M src-db/database/model/functions/M_INTERNAL_CONSUMPTION_POST.xml
M src-db/database/model/functions/M_INVENTORY_POST.xml
M src-db/database/model/functions/M_MOVEMENT_POST.xml
M src-db/database/model/functions/M_PRODUCTION_RUN.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG.xml
---
(0020022)
hudsonbot   
2009-09-15 09:45   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-inc-pgsql/865/ [^]
------
(0020029)
hudsonbot   
2009-09-15 09:50   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-inc-oracle/758/ [^]
------
(0020041)
hudsonbot   
2009-09-15 10:57   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-inc-pgsql/866/ [^]
------
(0020047)
hudsonbot   
2009-09-15 11:09   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-inc-oracle/759/ [^]
------
(0020054)
hudsonbot   
2009-09-15 12:12   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-module-installation-test/99/ [^]
------
(0020055)
hudsonbot   
2009-09-15 12:27   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-full-oracle/348/ [^]
------
(0020069)
hudsonbot   
2009-09-15 12:36   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-pgsql-db-full-consistency-test/179/ [^]
------
(0020070)
hudsonbot   
2009-09-15 12:52   
Fixed Issue 10336

------
Integrated in http://builds.openbravo.com/job/erp_devel_pi-full-pgsql/354/ [^]
------
(0020110)
sureshbabu   
2009-09-16 14:04   
Tested working fine, when attribute set is already set for a product the system is allowing the user to create good shipment/receipt
(0020463)
hgbot   
2009-09-29 14:11   
Repository: erp/devel/pi-pageddatagrid
Changeset: 7185146af9f0f2c8e496221f399d0815d1783549
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Sun Sep 13 02:19:16 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/7185146af9f0f2c8e496221f399d0815d1783549 [^]

Fixes issue 10336 Now products which have both attribute set and attribute set value defined in the product window (they are completely define there), do not require to set the attribute set value in each transaction.

---
M src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
M src-db/database/model/functions/M_INOUT_POST.xml
M src-db/database/model/functions/M_INTERNAL_CONSUMPTION_POST.xml
M src-db/database/model/functions/M_INVENTORY_POST.xml
M src-db/database/model/functions/M_MOVEMENT_POST.xml
M src-db/database/model/functions/M_PRODUCTION_RUN.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG.xml
---
(0020752)
psarobe   
2009-10-06 11:22   
Closed again because hudson has reopened without no reason