Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010302Openbravo ERPA. Platformpublic2009-08-17 16:182009-10-23 00:00
Reporterplujan 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010302: Expired OBPS says that users will not be able to log in but they can
DescriptionAfter an OBPS site license expires, the message shown is "You need to renew the System's Openbravo Professional Subscription. Users will not be able to login, until you do so.". See attach.
Anyway, you can log in with no hard limit but only soft limit (you will receive a warning message since first new login but you can login with several users without getting the red error message).
Steps To ReproduceGo to any expired OBPS site and read the message about Subscription Status.
Lets assume that user limit is 3.
The requirement is that once expired only a single login will be allowed for system administrator task. Instead of this, you can login with more than three users. Everyone will get the warning message but restricted access is never triggered.
Proposed SolutionOnly a single user is allowed to login after expiration, so the message is correct and some extra verification is missing.
Additional Information
TagsOBPS-Security
Relationships
related to feature request 0011047 closed alostale Create a session management window 
Attached Filesgif Expired.GIF (50,718) 2009-08-17 16:18
https://issues.openbravo.com/file_download.php?file_id=1647&type=bug
gif
Issue History
Date ModifiedUsernameFieldChange
2009-08-17 16:18plujanNew Issue
2009-08-17 16:18plujanAssigned To => rafaroda
2009-08-17 16:18plujanFile Added: Expired.GIF
2009-08-17 16:31plujanTag Attached: OBPS-Security
2009-08-18 15:34rafarodaAssigned Torafaroda => alostale
2009-08-18 15:34rafarodaPrioritynormal => high
2009-08-18 15:34rafarodaSeverityminor => major
2009-08-18 15:34rafarodaStatusnew => scheduled
2009-08-18 18:53plujanDescription Updated
2009-08-18 18:53plujanProposed Solution updated
2009-08-18 18:53plujanSteps to Reproduce Updated
2009-10-20 10:52alostaleRelationship addedrelated to 0011047
2009-10-20 10:56hgbotCheckin
2009-10-20 10:56hgbotNote Added: 0021202
2009-10-20 10:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/584cfc61ece9194d24e80874d1155a81617afef6 [^]
2009-10-20 10:56hgbotCheckin
2009-10-20 10:56hgbotNote Added: 0021203
2009-10-20 10:56hgbotStatusscheduled => resolved
2009-10-20 10:56hgbotResolutionopen => fixed
2009-10-20 10:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/584cfc61ece9194d24e80874d1155a81617afef6 [^] => http://code.openbravo.com/erp/devel/pi/rev/aad744f6a167839199094297cff848fac66154af [^]
2009-10-20 16:13hgbotCheckin
2009-10-20 16:13hgbotNote Added: 0021215
2009-10-20 16:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/aad744f6a167839199094297cff848fac66154af [^] => http://code.openbravo.com/erp/devel/pi/rev/2c97818848a582313fcc9e66e5680035f5cab1a2 [^]
2009-10-21 10:44hgbotCheckin
2009-10-21 10:44hgbotNote Added: 0021250
2009-10-21 10:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2c97818848a582313fcc9e66e5680035f5cab1a2 [^] => http://code.openbravo.com/erp/devel/pi/rev/21b69ea05d3ed3caf599b7ab1b66580280d99940 [^]
2009-10-22 11:21plujanStatusresolved => closed
2009-10-22 16:50alostaleNote Added: 0021342
2009-10-23 00:00anonymoussf_bug_id0 => 2884245

Notes
(0021202)
hgbot   
2009-10-20 10:56   
Repository: erp/devel/pi
Changeset: 584cfc61ece9194d24e80874d1155a81617afef6
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Oct 20 10:03:19 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/584cfc61ece9194d24e80874d1155a81617afef6 [^]

issue 10302
When the license is expired only System Administrator is allowed to log into the application

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/base/secureApp/DefaultOptions_data.xsql
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/base/secureApp/Seguridad_data.xsql
M src/org/openbravo/erpCommon/ad_forms/Role.java
M src/org/openbravo/erpCommon/ad_forms/RoleCombo_data.xsql
---
(0021203)
hgbot   
2009-10-20 10:56   
Repository: erp/devel/pi
Changeset: aad744f6a167839199094297cff848fac66154af
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Oct 20 10:55:01 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/aad744f6a167839199094297cff848fac66154af [^]

fixed bug 10302:
Check also for expired licenses for module not to allow other roles than System to log in.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/erpCommon/ad_forms/Role.java
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0021215)
hgbot   
2009-10-20 16:13   
Repository: erp/devel/pi
Changeset: 2c97818848a582313fcc9e66e5680035f5cab1a2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Oct 20 11:12:21 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2c97818848a582313fcc9e66e5680035f5cab1a2 [^]

issue 0010302: Prevent NPE when checking expired modules

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0021250)
hgbot   
2009-10-21 10:44   
Repository: erp/devel/pi
Changeset: 21b69ea05d3ed3caf599b7ab1b66580280d99940
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Oct 21 10:43:51 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/21b69ea05d3ed3caf599b7ab1b66580280d99940 [^]

issue 10302:

Do not take into account current session for checking number of active sessions

---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/erpCommon/ad_forms/Role.java
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0021342)
alostale   
2009-10-22 16:50   
Documentation:
http://wiki.openbravo.com/wiki/ERP/2.50/Professional_Subscription_Manual#License_Expiration [^]