Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010276Openbravo ERP09. Financial managementpublic2009-08-14 11:132009-10-14 00:00
Reporternetworkb 
Assigned Todalsasua 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40MP7 
Target Version2.40MP10Fixed in Version2.50MP7 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010276: AR Credit Memo is not well posted if it is used as document cancelled
DescriptionIf AR Credit Memo is selected as document cancelled of AR Invoice (I mean, when an AR Invoice is cancelled, a new invoice will be created using AR Credit memo document), is not well posted.
Its GL entry shows all amounts in negative, but it must be shown in positive because of document type.
Steps To ReproduceGo to Financial Management > Accounting > Setup > Document type.
Search AR Invoice.
Select as Document cancelled, AR Credit Memo. Save it.
Go to Sales Management > Transactions > Sales Invoice.
Generate a new one, using AR Invoice as Document transaction.
Generate also its lines.
Complete it.
Void it. As a result a new invoice is created (see description). This new invoice will use AR Credit memo document transaction.
Go to this sales invoice.
Post it.
Its amounts are negative, and it should be positive.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0009236 closed vmromanos If you void an invoice with document type defined as "AR Credit memo", the new invoice created is posted incorrectly 
depends on backport 00104802.40MP10 closed dalsasua AR Credit Memo is not well posted if it is used as document cancelled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-08-14 11:13networkbNew Issue
2009-08-14 11:13networkbAssigned To => rafaroda
2009-08-14 11:20networkbNote Added: 0018945
2009-08-14 12:26psarobeAssigned Torafaroda => dalsasua
2009-08-14 12:26psarobePriorityimmediate => urgent
2009-08-14 12:26psarobeStatusnew => feedback
2009-08-14 12:27psarobeNote Added: 0018948
2009-08-14 12:42rafarodaRelationship addedrelated to 0009236
2009-08-19 07:14rafarodaNote Added: 0019027
2009-08-24 09:57networkbNote Added: 0019183
2009-08-24 09:57networkbStatusfeedback => new
2009-08-24 10:08networkbTarget Version => 2.40MP10
2009-09-03 17:41dalsasuaStatusnew => scheduled
2009-09-03 17:41dalsasuaNote Added: 0019457
2009-09-03 17:41dalsasuafix_in_branch => pi
2009-09-03 18:19dalsasuaNote Edited: 0019457
2009-09-03 18:20dalsasuaStatusscheduled => acknowledged
2009-09-03 18:20dalsasuaStatusacknowledged => scheduled
2009-09-08 12:27jpcalventeIssue Monitored: jpcalvente
2009-09-21 09:35networkbNote Added: 0020225
2009-09-21 12:27dalsasuaNote Added: 0020233
2009-09-21 13:40hgbotCheckin
2009-09-21 13:40hgbotNote Added: 0020242
2009-09-21 13:40hgbotStatusscheduled => resolved
2009-09-21 13:40hgbotResolutionopen => fixed
2009-09-21 13:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/de207dee755dd325135c1d9138643958681b9ca7 [^]
2009-09-21 13:57hgbotCheckin
2009-09-21 13:57hgbotNote Added: 0020245
2009-09-21 13:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.40/rev/de207dee755dd325135c1d9138643958681b9ca7 [^] => http://code.openbravo.com/erp/devel/pi/rev/94b9fe71dc7eb5ee932190c17dca67a82b04e008 [^]
2009-09-21 13:58dalsasuaStatusresolved => new
2009-09-21 13:58dalsasuaResolutionfixed => open
2009-09-21 13:58dalsasuaNote Deleted: 0020242
2009-09-21 14:07dalsasuaStatusnew => scheduled
2009-09-21 14:07dalsasuaStatusscheduled => resolved
2009-09-21 14:07dalsasuaResolutionopen => fixed
2009-09-22 12:20psarobeStatusresolved => new
2009-09-22 12:20psarobeResolutionfixed => open
2009-09-22 12:20psarobeNote Added: 0020265
2009-09-22 12:21psarobeStatusnew => scheduled
2009-09-28 17:00dalsasuaNote Added: 0020411
2009-09-28 18:37hgbotCheckin
2009-09-28 18:37hgbotNote Added: 0020413
2009-09-28 18:37hgbotStatusscheduled => resolved
2009-09-28 18:37hgbotResolutionopen => fixed
2009-09-28 18:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/94b9fe71dc7eb5ee932190c17dca67a82b04e008 [^] => http://code.openbravo.com/erp/devel/pi/rev/e14e38097b945552226fed6dde40f86f279a3c29 [^]
2009-09-29 12:02hgbotCheckin
2009-09-29 12:02hgbotNote Added: 0020441
2009-09-29 12:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e14e38097b945552226fed6dde40f86f279a3c29 [^] => http://code.openbravo.com/erp/stable/2.40_pageddatagrid/rev/de207dee755dd325135c1d9138643958681b9ca7 [^]
2009-09-29 14:14hgbotCheckin
2009-09-29 14:14hgbotNote Added: 0020490
2009-09-29 14:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.40_pageddatagrid/rev/de207dee755dd325135c1d9138643958681b9ca7 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/94b9fe71dc7eb5ee932190c17dca67a82b04e008 [^]
2009-09-29 14:19hgbotCheckin
2009-09-29 14:19hgbotNote Added: 0020523
2009-09-29 14:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/94b9fe71dc7eb5ee932190c17dca67a82b04e008 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/e14e38097b945552226fed6dde40f86f279a3c29 [^]
2009-10-13 08:46sureshbabuStatusresolved => closed
2009-10-13 08:46sureshbabuNote Added: 0020956
2009-10-13 08:47sureshbabuFixed in Version => 2.50MP7
2009-10-14 00:00anonymoussf_bug_id0 => 2878309

Notes
(0018945)
networkb   
2009-08-14 11:20   
In fact the error is in voiding process. It should take into account the document type of voided invoice. In case of AR Credit Memo, pay attention that the way it's posted.It's posted the oposite an AR invoice
(0018948)
psarobe   
2009-08-14 12:27   
Dalsasua,

Does it make sense what they are trying to do?
(0019027)
rafaroda   
2009-08-19 07:14   
Reminder sent to: dalsasua

David,

Can you please comment on this OBPS issue?

Thanks.
(0019183)
networkb   
2009-08-24 09:57   
It is supposed that a cancellation document type can be used when a document type is defined. If it is possible, its GL entry should be right according with document type
(0019457)
dalsasua   
2009-09-03 17:41   
(edited on: 2009-09-03 18:19)
I have only been able to reproduce it in pi and 2.40: not in 2.35
(0020225)
networkb   
2009-09-21 09:35   
The bug was reported in 2.40, not 2.35
(0020233)
dalsasua   
2009-09-21 12:27   
This bug is a regression introduced in the fix to the bug 0009236. This fix was applied to 2.40 and pi repositories.
(0020245)
hgbot   
2009-09-21 13:57   
Repository: erp/devel/pi
Changeset: 94b9fe71dc7eb5ee932190c17dca67a82b04e008
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 21 13:57:15 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/94b9fe71dc7eb5ee932190c17dca67a82b04e008 [^]

Fixes issue 10276: AR Credit Memo is not well posted
if it is used as document cancelled

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020265)
psarobe   
2009-09-22 12:20   
The payment is created incorrectly so the GL entry is not correct
(0020411)
dalsasua   
2009-09-28 17:00   
I finally realized that this is not a bug:

- posting process of credit memos is correct
- void process of invoices is correct
- credit memo is not a suitable document to be the document canceled of invoices

The idea of document canceled option in document type window is to have a document with same processing and posting logic that the original one. Actually, when a document is voided, a new document is created with negative amounts in the lines. Credit Memos are designed to act very different to what invoices do.

Action taken: credit memos are no more available in the combo of canceled documents.

Regards.
(0020413)
hgbot   
2009-09-28 18:37   
Repository: erp/devel/pi
Changeset: e14e38097b945552226fed6dde40f86f279a3c29
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 28 18:36:13 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e14e38097b945552226fed6dde40f86f279a3c29 [^]

Fixes Issue 10276: AR Credit Memo is not well posted
if it is used as document cancelled

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020441)
hgbot   
2009-09-29 12:02   
Repository: erp/stable/2.40_pageddatagrid
Changeset: de207dee755dd325135c1d9138643958681b9ca7
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 21 13:39:03 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40_pageddatagrid/rev/de207dee755dd325135c1d9138643958681b9ca7 [^]

Fixes issue 10276: AR Credit Memo is not well posted
if it is used as document cancelled

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020490)
hgbot   
2009-09-29 14:14   
Repository: erp/devel/pi-pageddatagrid
Changeset: 94b9fe71dc7eb5ee932190c17dca67a82b04e008
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 21 13:57:15 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/94b9fe71dc7eb5ee932190c17dca67a82b04e008 [^]

Fixes issue 10276: AR Credit Memo is not well posted
if it is used as document cancelled

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020523)
hgbot   
2009-09-29 14:19   
Repository: erp/devel/pi-pageddatagrid
Changeset: e14e38097b945552226fed6dde40f86f279a3c29
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 28 18:36:13 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/e14e38097b945552226fed6dde40f86f279a3c29 [^]

Fixes Issue 10276: AR Credit Memo is not well posted
if it is used as document cancelled

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020956)
sureshbabu   
2009-10-13 08:46   
Tested, working fine (credit memos are no more available in the combo of canceled documents.)