0010236: DalWebService.java - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0010236

Openbravo ERP

A. Platform

public

2009-08-11 12:55

2009-10-22 12:00

Reporter

sgue0065

Assigned To

iperdomo

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0010236: DalWebService.java

Description

In the service-methods a call to

response.setHeader("Content-Encoding", "UTF-8");

is done in several places. This is wrong!

see http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.11 [^] [^]

The setting is used to set for example a compression scheme, but not the character-enconding. Not shure, but what you probably want to do is to set a Content-Transfer-Encoding

Steps To Reproduce

Call the rest service not from a browser, but for example from Axis 2. You get an exception upon an unknown "Content-Encoding".

package de.his.appserver.ws.rm.fim;

import java.net.URLEncoder;
import java.util.Iterator;

import javax.xml.namespace.QName;

import org.apache.axiom.om.OMAbstractFactory;
import org.apache.axiom.om.OMElement;
import org.apache.axiom.om.OMFactory;
import org.apache.axis2.Constants;
import org.apache.axis2.addressing.EndpointReference;
import org.apache.axis2.client.Options;
import org.apache.axis2.client.ServiceClient;

import de.his.core.util.junit.TestOwner;

/**
* @author GUENTHER
* @version $Id$
* Testklasse für Rest-Webservices zwischen OpenBravo und H1
*/
@TestOwner(cvsLogin = "guenther#his.de")
public class OpenBravoRestTest extends junit.framework.TestCase {


    /**
     * Store the texts read by NavigationURL
     */
    private String snippet;

    public String searchOpenBravoEntities() {
        try {
            snippet = "";
            String epr = "http://localhost:8080/openbravo/ws/dal?l=Openbravo&p=openbravo"; [^] [^]

            ServiceClient client = new ServiceClient();
            Options options = new Options();
            options.setProperty(org.apache.axis2.Constants.Configuration.CHARACTER_SET_ENCODING, "UTF-8");
            options.setProperty(Constants.Configuration.ENABLE_REST, Boolean.TRUE);
            options.setProperty(Constants.Configuration.HTTP_METHOD, Constants.Configuration.HTTP_METHOD_GET);
            options.setProperty(Constants.Configuration.MESSAGE_TYPE,
                org.apache.axis2.transport.http.HTTPConstants.MEDIA_TYPE_TEXT_XML);
            options.setProperty(Constants.Configuration.DISABLE_SOAP_ACTION, Constants.VALUE_TRUE);
            options.setCallTransportCleanup(true);
            options.setTransportInProtocol(Constants.TRANSPORT_HTTP);
            options.setTo(new EndpointReference(epr));

            client.setOptions(options);

            //if post is through GET of HTTP
            OMElement response = client.sendReceive(null);
            generateSnippet(response);
            return snippet;

        } catch (Exception e) {
            e.printStackTrace();
            snippet = e.getMessage();
        }
        return null;
    }

    private void generateSnippet(OMElement response) {
        String title = null;

        snippet="";

        QName qname= new QName("entityName");
        OMElement result = null;
        //get an iterator for Result elements
        Iterator itr = response.getChildElements();
        while (itr.hasNext()) {
            result = (OMElement) itr.next();


            title=result.getAttributeValue(qname);

            snippet += " "+title;
            System.out.println(title);
        }
    }


    public void testRestCall(){
        String test=searchOpenBravoEntities();
        System.out.println(snippet);
    }


}

Proposed Solution

Quick solution is delete all calls to

response.setHeader("Content-Encoding", "UTF-8");

the bug seems to be introduced after MP1 and is in MP2. it is in the current HEAD or main. I have not tried to do a direct MP3 checkout.

Additional Information