Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010201Openbravo ERPA. Platformpublic2009-08-06 11:302012-04-01 20:37
Reporterpjuvara 
Assigned Toguilleaer 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP3 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010201: Revision ID in the About window is not properly set in Ubuntu installation or with upgrade
DescriptionStarting with 2.50 MP3 the about window identify the current version of the system with three attributes:
* Label: example 2.50 MP3
* Version: example 2.50.14398
* Revision ID: this is the Mercurial changeset ID from which the version was packaged

This works fine for new Community Appliance installations but it does not work properly for upgraded appliances or for new Ubuntu installations.

I am not sure if this is a problem with the platform itself or it is the result of a packaging mistake.
Steps To ReproduceFor Community Appliance:
1) Install a fresh 2.50 MP3 Appliance and go to the about box, the revision ID is there. This is correct.
2) Install a fresh 2.50 MP1 or MP2 Appliance, download the 2.50 MP3 obx file and upgrade the Appliance to MP3 level. Go the about box: the revision ID is not there.

For Ubuntu:
1) Install a fresh Ubuntu Openbravo package (sudo apt-get install openbravo-erp). Go to the about box: the revision ID is not there.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng error2.PNG (48,284) 2009-08-06 17:08
https://issues.openbravo.com/file_download.php?file_id=1626&type=bug
png

png error3.PNG (21,089) 2009-09-01 19:01
https://issues.openbravo.com/file_download.php?file_id=1700&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2009-08-06 11:30pjuvaraNew Issue
2009-08-06 11:30pjuvaraAssigned To => rafaroda
2009-08-06 17:08psarobeNote Added: 0018867
2009-08-06 17:08psarobeFile Added: error2.PNG
2009-08-06 17:10psarobeAssigned Torafaroda => marvintm
2009-08-06 17:10psarobePrioritynormal => urgent
2009-08-06 17:10psarobeStatusnew => scheduled
2009-09-01 19:01psarobeFile Added: error3.PNG
2009-09-01 19:22psarobeNote Added: 0019384
2009-09-25 12:19marvintmAssigned Tomarvintm => jpabloae
2009-11-12 16:46jpabloaeNote Added: 0021781
2011-08-24 12:58jpabloaeAssigned Tojpabloae => gorka_gil
2012-02-20 11:47gorka_gilAssigned Togorka_gil => alostale
2012-03-02 15:45alostaleAssigned Toalostale => guilleaer
2012-03-07 15:15hgbotCheckin
2012-03-07 15:15hgbotNote Added: 0046135
2012-03-07 15:15hgbotStatusscheduled => resolved
2012-03-07 15:15hgbotResolutionopen => fixed
2012-03-07 15:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b82a1d5eabd1f2a1b3f31425aad231db852d2db1 [^]
2012-03-07 15:25guilleaerNote Added: 0046137
2012-03-09 12:11alostaleNote Added: 0046228
2012-03-09 12:11alostaleStatusresolved => closed
2012-03-09 12:11alostaleFixed in Version => 3.0MP10
2012-04-01 20:37hudsonbotCheckin
2012-04-01 20:37hudsonbotNote Added: 0047053

Notes
(0018867)
psarobe   
2009-08-06 17:08   
It also happens something strange while upgrading from sources:
- Install mp2 from sources: changeset: b7d447cb0d2d
- Apply the mp3 obx

The result for those three fields are:

Label: 250 (This is why I put for MP2) so that means it didn't update it to 250MP3
Version number: did it correct: 2.50.13498
Version Id: It maintain the changeset of MP2: b7d447cb0d2d

Please see attach
(0019384)
psarobe   
2009-09-01 19:22   
This also happens when upgrading from MP3 community appliance to MP5 using the obx file for MP5 (remember we don't have the obx file for MP4)

Version: 2.50.14827
Version Label: MP5
Version ID: ${instance.version}

See attach
(0021781)
jpabloae   
2009-11-12 16:46   
This is fixed in the Community Appliance, the OBX and the tarball.
Pending fix in Ubuntu.
(0046135)
hgbot   
2012-03-07 15:15   
Repository: erp/devel/pi
Changeset: b82a1d5eabd1f2a1b3f31425aad231db852d2db1
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Mar 07 15:09:50 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b82a1d5eabd1f2a1b3f31425aad231db852d2db1 [^]

Fixed issue 10201: The core revision Id of about page is shown correctly

ant install.source tries to get the current revision from merurial. If mercurial isn't present it try to get from file (config/instance.version). In case of both aren't present a '-' will be write. It is better than show an ant variable instance.version

---
M src/build.xml
---
(0046137)
guilleaer   
2012-03-07 15:25   
Tested for 3.0 using an instance without mercurial and without config/instance.version file.

Test Plan:
run ant.source in this cases, run OB and take a view of the about page.
1. Instance with mercurial. -> core revision Id = hg id
2. Instance without mercurial but with config/instance.version field -> The revision will be gotten from file.
3. Instance without mercurial and without file -> Core revision Id = -

This change is not risky
(0046228)
alostale   
2012-03-09 12:11   
Code reviewed ant tested on pi@4fdfa4d1c5ba
(0047053)
hudsonbot   
2012-04-01 20:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^]

Maturity status: Test