Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010134Openbravo ERPA. Platformpublic2009-07-30 15:392009-08-07 15:43
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target VersionFixed in Version2.40MP8 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010134: Generated windows still execute code for old keyboard shortcut system which is then later not used.
DescriptionThe generated servlets for edit- & grid-view still run code code (including a database query) for some old keyboard shortcut system (class KeyMap.java). However the result of this code is then discarded when building the html with xmlEngine.

To improve performance the code should be removed to not execute this unused database query.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0010133 closed shuehner Generated windows still execute code for old keyboard shortcut system which is then later not used. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-30 15:39shuehnerTypedefect => backport
2009-07-30 15:39shuehnerfix_in_branch => 2.40
2009-07-30 16:38hgbotCheckin
2009-07-30 16:38hgbotNote Added: 0018725
2009-07-30 16:38hgbotStatusscheduled => resolved
2009-07-30 16:38hgbotResolutionopen => fixed
2009-07-30 16:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/80d503f37e75a060577324b2421544282f397565 [^]
2009-07-30 18:20shuehnerNote Added: 0018731
2009-08-07 15:43sureshbabuStatusresolved => closed
2009-08-07 15:43sureshbabuNote Added: 0018880
2009-08-07 15:43sureshbabuFixed in Version => 2.40MP8

Notes
(0018725)
hgbot   
2009-07-30 16:38   
Repository: erp/stable/2.40
Changeset: 80d503f37e75a060577324b2421544282f397565
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 30 16:37:40 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/80d503f37e75a060577324b2421544282f397565 [^]

Fixed 10134: Remove unused code for old KeyMap keyboard shortcut system
- Removes one unneeded database query from each generated window

---
M src-wad/src/org/openbravo/wad/Configuration_Edition.xmlxml
M src-wad/src/org/openbravo/wad/Configuration_Relation.xmlxml
M src-wad/src/org/openbravo/wad/Template_Edition.html
M src-wad/src/org/openbravo/wad/Template_Relation.html
M src-wad/src/org/openbravo/wad/javasource.javaxml
---
(0018731)
shuehner   
2009-07-30 18:20   
@qa: This should introduce not user visible change in behavior.

All keyboard shortcuts which did work before should still work:

List of shortcuts can be found at [1]:

[1] http://wiki.openbravo.com/wiki/Projects/KeyboardOperation/FunctionalSpecifications [^]
(0018880)
sureshbabu   
2009-08-07 15:43   
Tested the list of Keyboard keys given in the page

http://wiki.openbravo.com/wiki/Projects/KeyboardOperation/FunctionalSpecifications [^]

working fine