Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0010091 | Openbravo ERP | A. Platform | public | 2009-07-28 15:44 | 2012-04-01 20:37 |
|
| Reporter | psarobe | |
| Assigned To | guilleaer | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | 3.0MP10 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0010091: To run the ant task package.core you need to compile |
| Description | This is wrong. You should able to run this task without to compile |
| Steps To Reproduce | 1. Do a clone of PI
2. run the task ant package.core
you will see this error
BUILD SUCCESSFUL
Total time: 8 seconds
C:\OpenbravoERP-Main-obx\main>ant package.core
Buildfile: build.xml
set.code.rev:
code.rev:
init:
set.version.from.file:
set.version.calculated:
[echo] calculating core revision...
BUILD FAILED
C:\OpenbravoERP-Main-obx\main\build.xml:887: taskdef class org.openbravo.erpCommon.utility
.CalculateCoreRevision cannot be found |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0037496 | | closed | shuehner | CalculateCoreRevision class is unused and should be removed |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2009-07-28 15:44 | psarobe | New Issue | |
| 2009-07-28 15:44 | psarobe | Assigned To | => rafaroda |
| 2009-07-28 15:44 | psarobe | Status | new => scheduled |
| 2009-07-28 15:44 | psarobe | Assigned To | rafaroda => shuehner |
| 2009-07-28 15:44 | psarobe | fix_in_branch | => pi |
| 2009-07-28 15:53 | shuehner | Note Added: 0018660 | |
| 2011-05-20 15:13 | psarobe | Note Added: 0037281 | |
| 2011-05-20 15:13 | psarobe | Target Version | => 3.0MP0 |
| 2011-05-20 15:13 | psarobe | fix_in_branch | pi => |
| 2011-05-20 15:13 | psarobe | Priority | high => urgent |
| 2011-05-23 13:13 | shuehner | Note Added: 0037321 | |
| 2011-05-23 13:13 | shuehner | Priority | urgent => normal |
| 2011-05-23 13:46 | psarobe | Target Version | 3.0MP0 => 3.0MP1 |
| 2011-06-22 19:57 | dmitry_mezentsev | Target Version | 3.0MP1 => 3.0MP2 |
| 2011-08-02 12:46 | shuehner | Note Added: 0039770 | |
| 2011-08-02 12:46 | shuehner | Target Version | 3.0MP2 => |
| 2012-02-20 11:19 | shuehner | Assigned To | shuehner => alostale |
| 2012-02-22 09:45 | alostale | Assigned To | alostale => guilleaer |
| 2012-03-05 15:40 | hgbot | Checkin | |
| 2012-03-05 15:40 | hgbot | Note Added: 0046044 | |
| 2012-03-05 15:40 | hgbot | Status | scheduled => resolved |
| 2012-03-05 15:40 | hgbot | Resolution | open => fixed |
| 2012-03-05 15:40 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/cd0c49fbd501929417bedbdf90c6bcd6db11330a [^] |
| 2012-03-07 11:15 | guilleaer | Note Added: 0046122 | |
| 2012-03-09 12:08 | alostale | Note Added: 0046227 | |
| 2012-03-09 12:08 | alostale | Status | resolved => closed |
| 2012-03-09 12:08 | alostale | Fixed in Version | => 3.0MP10 |
| 2012-04-01 20:37 | hudsonbot | Checkin | |
| 2012-04-01 20:37 | hudsonbot | Note Added: 0047032 | |
| 2017-12-16 17:38 | shuehner | Relationship added | related to 0037496 |
|
Notes |
|
|
|
|
The package.core task just uses one single java file. Problem is that this file is contained in src/ forcing the user to do full slow compile cycle. Moving the file to src-core and adding core.lib dependency to the package.core subtasks solves this easily. |
|
|
|
|
|
Requires an api-change so better doing before mp0 |
|
|
|
|
|
update to priority normal: nice to have, but not must for mp0 |
|
|
|
|
|
postponing as doesn't fit in mp2 |
|
|
|
(0046044)
|
|
hgbot
|
|
2012-03-05 15:40
|
|
Repository: erp/devel/pi
Changeset: cd0c49fbd501929417bedbdf90c6bcd6db11330a
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Mar 02 10:57:07 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cd0c49fbd501929417bedbdf90c6bcd6db11330a [^]
Fixed issue 10091: Now run ant package.core is possible without compile
The tasks that were done in java file now are done using ant.
---
M build.xml
M src/org/openbravo/erpCommon/utility/CalculateCoreRevision.java
---
|
|
|
|
|
Test plan
---------
1. Execute the command "ant package.core" in the terminal.
2. This task will be done without using the java class (CalculateCoreRevision.java).
Now this task doesn't need a full compilation.
Regression risk
---------------
ant package.core has been changed but its behavior shouldn't be changed |
|
|
|
|
|
Code reviewed and tested on pi@4fdfa4d1c5ba |
|
|
|
|
|