Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010001Openbravo ERPZ. Otherspublic2009-07-22 19:362010-10-14 00:00
Reportershuehner 
Assigned Toharikrishnan 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP23 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010001: Report should/must use ComboTableData with #AccessibleOrgTree for Organization dropdown
DescriptionSome report (see below for list) do not use ComboTableData to render the Organization drop list. This way they do not show show sub-organizations under an org which a role has accees to if the role has not direct access to the sub org.

Example:
See steps to reproduce

List of affected reports (all using the OrganizationComboData class instead of ComboTableData:
- ExpenseSOrder (ad_actionbutton, manual popup)
- ChangeOrderOrg (ad_process)
- PrintInvoices (ad_process)

ad_reports:
GenerateModel347
ReportAccountingCountDimensionalAnalyses
ReportInvoiceCustomerDimensionalAnalyses
ReportinvoiceCustomerDimensionalAnalysesJR
ReportInvoiceVendorDimensionalAnalysesJR
ReportMaterialDimensionalAnalysesJR
ReportOrderNotInvoiceJR
ReportPurchaseDimensionalAnalysesJR
ReportRefundInvoiceCustomerDimensionalAnalyses
ReportRefundSalesDimensionalAnalyses
ReportSalesDimensionalAnalyzeJR
ReportShipmentDimensionalAnalyzeJR
ReportTaxInvoice
ReportTaxInvoiceJR
Steps To ReproduceUse demo client small-bazaar
Goto general setup -> security -> Role
select the "RoleA" role
goto Org Access
delete all org access rows for this role starting with B (B, B1, B11, ...)
switch role to RoleA
Goto Financials -> Receivables & Payables -> Analysis Tools -> Invoice Taxes Reports
Check the organization combo box, it does not contain any organization which start with B.

But, it should contain these organization entries, as read access to main implies read access to all orgs under main and thus filtering/selecting any sub-org of main should be allowed.
Proposed Solution
Additional Information
Tagsreports_review
Relationships
related to defect 0009935 closed shuehner Several reports depend GeneralAccountingReports_data.xsql which makes customizations harder 
related to defect 00144792.50MP23 closed adrianromero Organization * is not showed in ReportTrialBalance 
related to defect 0015092 closed Sandrahuguet Some reports/processes still use the deprecated OrganizationComboData instead of the standard ComboTableData 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-22 19:36shuehnerNew Issue
2009-07-22 19:36shuehnerAssigned To => shuehner
2009-07-22 19:59shuehnerRelationship addedrelated to 0009935
2009-09-14 10:17psarobeStatusnew => scheduled
2009-09-14 10:17psarobeAssigned Toshuehner => rafaroda
2009-09-14 10:17psarobefix_in_branch => pi
2009-09-14 10:41rafarodaTag Attached: reports_review
2010-02-11 18:05rafarodaAssigned Torafaroda => adrianromero
2010-09-14 17:57shuehnerRelationship addedrelated to 0014479
2010-10-11 08:17harikrishnanAssigned Toadrianromero => harikrishnan
2010-10-11 08:18hgbotCheckin
2010-10-11 08:18hgbotNote Added: 0031725
2010-10-11 08:18hgbotStatusscheduled => resolved
2010-10-11 08:18hgbotResolutionopen => fixed
2010-10-11 08:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2ae1dcc889dc0849e637e25cf77992dc8b7f9a2a [^]
2010-10-11 08:19harikrishnanNote Added: 0031726
2010-10-11 10:29hgbotCheckin
2010-10-11 10:29hgbotNote Added: 0031742
2010-10-11 10:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2ae1dcc889dc0849e637e25cf77992dc8b7f9a2a [^] => http://code.openbravo.com/erp/devel/pi/rev/979c2d69343db6de7de5db54db74e41f38d07116 [^]
2010-10-11 15:18hudsonbotCheckin
2010-10-11 15:18hudsonbotNote Added: 0031763
2010-10-11 15:18hudsonbotCheckin
2010-10-11 15:18hudsonbotNote Added: 0031765
2010-10-13 18:40psarobeNote Added: 0031826
2010-10-13 18:40psarobeStatusresolved => closed
2010-10-13 18:40psarobeFixed in Version => 2.50MP23
2010-10-14 00:00anonymoussf_bug_id0 => 3086959
2010-11-02 12:14shuehnerRelationship addedrelated to 0015092

Notes
(0031725)
hgbot   
2010-10-11 08:18   
Repository: erp/devel/pi
Changeset: 2ae1dcc889dc0849e637e25cf77992dc8b7f9a2a
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Mon Oct 11 11:47:28 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/2ae1dcc889dc0849e637e25cf77992dc8b7f9a2a [^]

Fixes Issue 10001: Report should/must use ComboTableData with #AccessibleOrgTree for Organization dropdown

---
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.html
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.java
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.xml
M src/org/openbravo/erpCommon/ad_process/ChangeOrderOrg.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoiceJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportTaxInvoice.java
M src/org/openbravo/erpCommon/ad_reports/ReportTaxInvoiceJR.java
---
(0031726)
harikrishnan   
2010-10-11 08:19   
Steps To test:
Look in to this spreadsheet.
http://spreadsheets.google.com/a/openbravo.com/ccc?key=0AlwyfBxhtCeYdEZtUGpKUXQtVXItLUtVY3NjMTVOYlE&hl=en&authkey=CJyLwK4G [^]

Impact:

Their is no impact because of this fix.
(0031742)
hgbot   
2010-10-11 10:29   
Repository: erp/devel/pi
Changeset: 979c2d69343db6de7de5db54db74e41f38d07116
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Mon Oct 11 13:58:26 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/979c2d69343db6de7de5db54db74e41f38d07116 [^]

Fixes Issue 10001: Commit for DB consistency failure.

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0031763)
hudsonbot   
2010-10-11 15:18   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/2ae1dcc889dc [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f03dfdd6ea87 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18509.obx [^]
(0031765)
hudsonbot   
2010-10-11 15:18   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/979c2d69343d [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f03dfdd6ea87 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18509.obx [^]
(0031826)
psarobe   
2010-10-13 18:40   
Tested all the reports