# HG changeset patch
# User Shankar Balachandran <shankar.balachandran@openbravo.com>
# Date 1386050876 -19800
# Node ID 78dc5ddc6f5524f956bb5e7073d6373fdb28fae8
# Parent  778141ff967164c3313bda2a7ed48364d0e4da1a
Fixes Issue 0025162: Roles permissions are not working correctly

Checked whether the field is readOnly or shownInStatus bar before providing access to the field in case tab access is provided.

diff -r 778141ff9671 -r 78dc5ddc6f55 modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java	Thu Nov 28 14:43:09 2013 +0530
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java	Tue Dec 03 11:37:56 2013 +0530
@@ -113,7 +113,9 @@
             jTab.put("fields", jFields);
             final Set<String> fields = new TreeSet<String>();
             for (Field field : tabAccess.getTab().getADFieldList()) {
-              fields.add(KernelUtils.getProperty(entity, field).getName());
+              if (!field.isReadOnly() && !field.isShownInStatusBar()) {
+                fields.add(KernelUtils.getProperty(entity, field).getName());
+              }
             }
             for (FieldAccess fieldAccess : tabAccess.getADFieldAccessList()) {
               final String name = KernelUtils.getProperty(entity, fieldAccess.getField()).getName();