0008881: getCardType() in (PaymentGatewayPGNET class) returns wrong type of card

Description

If you are using American Express card, the current method will return a "DINE" string, which matches with Diners Club card.

Steps To Reproduce

Configure Openbravo POS 2.30 to use with PaymentsGateway.NET provider. [1]
In Configuration, select keyboard as Mag. Card Reader.
Make a sale and in Payment window, enter a valid card number starting with 34 or 37 (is the prefix of AmEx cards).
The application will process as a Diners Club card.

[1] http://wiki.openbravo.com/wiki/OpenbravoPOS_Payment_Gateways [^]

Proposed Solution

Change the order of if instructions.

else if (sCardNumber.startsWith("34") || sCardNumber.startsWith("37")) {
c = "AMER";
} else if (sCardNumber.startsWith("3")) {
c = "DINE";
}

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0016014) hgbot (developer) 2009-05-04 16:44	Repository: openbravopos Revision: 611 Author: mirurita Date: 2009-05-04 16:44:45 +0200 (Mon, 04 May 2009) Fixes issue 0008881: getCardType() in (PaymentGatewayPGNET class) returns wrong type of card --- U trunk/src-pos/com/openbravo/pos/payment/PaymentGatewayPGNET.java --- https://dev.openbravo.com/websvn/openbravopos/?rev=611&sc=1 [^]

(0065949) plujan (manager) 2014-04-02 09:03	Closed as it was in Resolved for too long

Issue History
Date Modified	Username	Field	Change
2009-05-04 16:39	mirurita	New Issue
2009-05-04 16:39	mirurita	Assigned To	=> mirurita
2009-05-04 16:44	hgbot	Checkin
2009-05-04 16:44	hgbot	Note Added: 0016014
2009-05-04 16:44	hgbot	Status	new => resolved
2009-05-04 16:44	hgbot	Resolution	open => fixed
2011-06-03 12:22	dalsasua	Assigned To	mirurita => adrianromero
2012-11-07 09:40	priyam	Category	01 - General => (No Category)
2014-04-02 09:03	plujan	Note Added: 0065949
2014-04-02 09:03	plujan	Status	resolved => closed